From a1ffce9eef6f6da9222ec5477c79b97d1e63452a Mon Sep 17 00:00:00 2001 From: abduhasen Date: Mon, 9 Mar 2026 00:50:17 +0000 Subject: [PATCH 1/4] removing unreachable and redundant code --- Sprint-3/3-dead-code/exercise-1.js | 11 ++--------- Sprint-3/3-dead-code/exercise-2.js | 6 ------ 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/Sprint-3/3-dead-code/exercise-1.js b/Sprint-3/3-dead-code/exercise-1.js index 4d09f15fa9..f7fa0f18b9 100644 --- a/Sprint-3/3-dead-code/exercise-1.js +++ b/Sprint-3/3-dead-code/exercise-1.js @@ -1,17 +1,10 @@ // Find the instances of unreachable and redundant code - remove them! // The sayHello function should continue to work for any reasonable input it's given. -let testName = "Jerry"; +let testName = "Chris"; const greeting = "hello"; function sayHello(greeting, name) { - const greetingStr = greeting + ", " + name + "!"; return `${greeting}, ${name}!`; - console.log(greetingStr); } - -testName = "Aman"; - -const greetingMessage = sayHello(greeting, testName); - -console.log(greetingMessage); // 'hello, Aman!' +console.log(sayHello(greeting, testName)); diff --git a/Sprint-3/3-dead-code/exercise-2.js b/Sprint-3/3-dead-code/exercise-2.js index 56d7887c4c..d0c5c50520 100644 --- a/Sprint-3/3-dead-code/exercise-2.js +++ b/Sprint-3/3-dead-code/exercise-2.js @@ -2,13 +2,7 @@ // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; -const capitalisedPets = pets.map((pet) => pet.toUpperCase()); const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); - -function logPets(petsArr) { - petsArr.forEach((pet) => console.log(pet)); -} - function countAndCapitalisePets(petsArr) { const petCount = {}; From 7d24e378de28c85f60bbade491e55f4b2f57b0fe Mon Sep 17 00:00:00 2001 From: abduhasen Date: Mon, 16 Mar 2026 13:55:59 +0000 Subject: [PATCH 2/4] fixing dead code based on mentor comment --- Sprint-3/3-dead-code/exercise-1.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Sprint-3/3-dead-code/exercise-1.js b/Sprint-3/3-dead-code/exercise-1.js index f7fa0f18b9..e177275e88 100644 --- a/Sprint-3/3-dead-code/exercise-1.js +++ b/Sprint-3/3-dead-code/exercise-1.js @@ -1,10 +1,15 @@ // Find the instances of unreachable and redundant code - remove them! // The sayHello function should continue to work for any reasonable input it's given. -let testName = "Chris"; const greeting = "hello"; function sayHello(greeting, name) { + const greetingStr = greeting + ", " + name + "!"; return `${greeting}, ${name}!`; } -console.log(sayHello(greeting, testName)); + +testName = "Aman"; + +const greetingMessage = sayHello(greeting, testName); + +console.log(greetingMessage); // 'hello, Aman!' From 3644abffdac04e1af3f6dca6a43bebcc20a37e24 Mon Sep 17 00:00:00 2001 From: abduhasen Date: Mon, 16 Mar 2026 14:00:52 +0000 Subject: [PATCH 3/4] removing dead code --- Sprint-3/3-dead-code/exercise-1.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Sprint-3/3-dead-code/exercise-1.js b/Sprint-3/3-dead-code/exercise-1.js index e177275e88..e51f0e5871 100644 --- a/Sprint-3/3-dead-code/exercise-1.js +++ b/Sprint-3/3-dead-code/exercise-1.js @@ -4,7 +4,6 @@ const greeting = "hello"; function sayHello(greeting, name) { - const greetingStr = greeting + ", " + name + "!"; return `${greeting}, ${name}!`; } From f3f16c972d8ef36391545a8529866add793bad1d Mon Sep 17 00:00:00 2001 From: abduhasen Date: Tue, 17 Mar 2026 02:22:41 +0000 Subject: [PATCH 4/4] fixing dead code --- Sprint-3/3-dead-code/exercise-1.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sprint-3/3-dead-code/exercise-1.js b/Sprint-3/3-dead-code/exercise-1.js index e51f0e5871..2e46fba356 100644 --- a/Sprint-3/3-dead-code/exercise-1.js +++ b/Sprint-3/3-dead-code/exercise-1.js @@ -7,7 +7,7 @@ function sayHello(greeting, name) { return `${greeting}, ${name}!`; } -testName = "Aman"; +let testName = "Aman"; const greetingMessage = sayHello(greeting, testName);