Fix number type conversion to use invariant culture in FieldConverter

Havret · Havret · commit c2e39aff9d63 · 2025-11-20T23:00:18.000+01:00
diff --git a/src/Protobuf.System.Text.Json/InternalConverters/FieldConverter.cs b/src/Protobuf.System.Text.Json/InternalConverters/FieldConverter.cs
@@ -1,5 +1,6 @@
 using System.Buffers;
 using System.Diagnostics;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using Google.Protobuf;
@@ -37,7 +38,7 @@ public override void Read(ref Utf8JsonReader reader, IMessage obj, Type typeToCo
 
         if (_isConverterForNumberType && reader.TokenType == JsonTokenType.String && (JsonNumberHandling.AllowReadingFromString & options.NumberHandling) != 0)
         {
-            var value = Convert.ChangeType(reader.GetString(), typeToConvert);
+            var value = Convert.ChangeType(reader.GetString(), typeToConvert, CultureInfo.InvariantCulture);
             fieldAccessor.SetValue(obj, value);
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using System.Buffers;`
`2`	`2`	`using System.Diagnostics;`
	`3`	`+using System.Globalization;`
`3`	`4`	`using System.Text.Json;`
`4`	`5`	`using System.Text.Json.Serialization;`
`5`	`6`	`using Google.Protobuf;`
`@@ -37,7 +38,7 @@ public override void Read(ref Utf8JsonReader reader, IMessage obj, Type typeToCo`
`37`	`38`
`38`	`39`	`if (_isConverterForNumberType && reader.TokenType == JsonTokenType.String && (JsonNumberHandling.AllowReadingFromString & options.NumberHandling) != 0)`
`39`	`40`	`{`
`40`		`- var value = Convert.ChangeType(reader.GetString(), typeToConvert);`
	`41`	`+ var value = Convert.ChangeType(reader.GetString(), typeToConvert, CultureInfo.InvariantCulture);`
`41`	`42`	`fieldAccessor.SetValue(obj, value);`
`42`	`43`	`}`
`43`	`44`	`else`