It would be an API breaking change, but I'd also strongly encourage:
- Moving
RE_DEFAULT_PIN, RE_DEFAULT_STEPS, and RE_LOOP_INTERVAL to class static constants (rather than global).
- Moving
EncoderType to a class scope enum (rather than global).
- Moving
RotaryEncoder::loop() into private scope.
Originally posted by @cleishm in #18 (comment)
It would be an API breaking change, but I'd also strongly encourage:
RE_DEFAULT_PIN,RE_DEFAULT_STEPS, andRE_LOOP_INTERVALto class static constants (rather than global).EncoderTypeto a class scope enum (rather than global).RotaryEncoder::loop()into private scope.Originally posted by @cleishm in #18 (comment)