refactor(xml): remove Xml.serialize extern

Author: pchalamet

CHANGELOG.md

@@ -4,6 +4,7 @@ All notable changes to FScript are documented in this file.
 
 ## [Unreleased]
 
+- Removed `Xml.serialize` from runtime externs; `Xml.deserialize` remains available.
 - Made `String.replace`, `String.indexOf`, `String.substring`, and `String.split` consistently pipeline-friendly by using data-last argument order.
 
 ## [0.55.0]

docs/specs/external-functions.md

@@ -95,12 +95,11 @@ Higher-order externs are implemented in runtime extern modules and receive an `E
 - `Json.deserialize : type -> string -> 'a option`
 - `Json.serialize : 'a -> string option`
 - `Xml.deserialize : type -> string -> string -> 'a list option`
-- `Xml.serialize : 'a -> string option`
 
 ## Error and option behavior
 - Type/arity mismatch in extern calls raises eval errors.
 - Many data/IO externs return `None` on operational failures (parse/IO/regex failures), rather than throwing.
-- `Xml.deserialize` and `Xml.serialize` do not support XML namespaces.
+- `Xml.deserialize` does not support XML namespaces.
 
 ## Extending with new externs
 Recommended steps:

src/FScript.Runtime/Registry.fs

@@ -21,5 +21,4 @@ module Registry =
           PrintExterns.print
           JsonExterns.deserialize
           JsonExterns.serialize
-          XmlExterns.deserialize
-          XmlExterns.serialize ]
+          XmlExterns.deserialize ]

src/FScript.Runtime/XmlExterns.fs

@@ -37,14 +37,3 @@ module XmlExterns =
                       |> Option.defaultValue HostCommon.none
                   with _ -> HostCommon.none
               | _ -> raise (HostCommon.evalError "Xml.deserialize expects (type, xml, query)") }
-
-    let serialize : ExternalFunction =
-        { Name = "Xml.serialize"
-          Scheme = Forall([ 0 ], TFun(TVar 0, TOption TString))
-          Arity = 1
-          Impl = fun _ -> function
-              | [ value ] ->
-                  match HostEncode.encodeXml value with
-                  | Some encoded -> HostCommon.some (VString encoded)
-                  | None -> HostCommon.none
-              | _ -> raise (HostCommon.evalError "Xml.serialize expects (value)") }

tests/FScript.Language.Tests/HostExternTests.fs

@@ -348,14 +348,11 @@ type HostExternTests () =
         | _ -> Assert.Fail("Expected Some serialized json")
 
     [<Test>]
-    member _.``Xml deserialize and serialize work with record payloads`` () =
+    member _.``Xml deserialize works with record payloads`` () =
         let script =
             "type Item = { Name: string }\n" +
-            "type Payload = { Item: Item }\n" +
-            "let payload = Xml.serialize { Item = { Name = \"x\" } }\n" +
-            "match payload with\n" +
-            "| Some xml -> Xml.deserialize (typeof Item) xml \"Item\"\n" +
-            "| None -> None"
+            "let xml = \"<root><Item><Name>x</Name></Item></root>\"\n" +
+            "Xml.deserialize (typeof Item) xml \"Item\""
 
         match Helpers.evalWithExterns externs script with
         | VOption (Some (VList [ VRecord fields ])) ->

tests/FScript.Runtime.Tests/RegistryTests.fs

@@ -31,4 +31,4 @@ type RegistryTests () =
         names.Contains "Json.deserialize" |> should equal true
         names.Contains "Json.serialize" |> should equal true
         names.Contains "Xml.deserialize" |> should equal true
-        names.Contains "Xml.serialize" |> should equal true
+        names.Contains "Xml.serialize" |> should equal false

tests/FScript.Runtime.Tests/XmlExternsTests.fs

@@ -13,19 +13,3 @@ type XmlExternsTests () =
         match invoke XmlExterns.deserialize [ VTypeToken TInt; VString xml; VString "items/item" ] with
         | VOption (Some (VList [ VInt 1L; VInt 2L ])) -> ()
         | _ -> Assert.Fail("Expected two ints")
-
-    [<Test>]
-    member _.``xml_serialize encodes record values`` () =
-        let value = VRecord (Map.ofList [ "Name", VString "pkg"; "Enabled", VBool true ])
-        match invoke XmlExterns.serialize [ value ] with
-        | VOption (Some (VString xml)) ->
-            Assert.That(xml, Does.Contain("<root>"))
-            Assert.That(xml, Does.Contain("<Name>pkg</Name>"))
-            Assert.That(xml, Does.Contain("<Enabled>true</Enabled>"))
-        | _ -> Assert.Fail("Expected serialized XML")
-
-    [<Test>]
-    member _.``xml_serialize returns None for non-record top-level`` () =
-        match invoke XmlExterns.serialize [ VList [ VInt 1L; VInt 2L ] ] with
-        | VOption None -> ()
-        | _ -> Assert.Fail("Expected None")