From 88761ca45950e478e230c7b369192af841f27990 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Thu, 26 Feb 2026 17:21:21 +0400 Subject: [PATCH] fix: lower Node.js minimum to >=20.0.0 for drizzle, typeorm, and mikroorm The only Node 24-specific API used was the `name` option on AsyncLocalStorage, which is a debugging aid with no runtime impact. Removing it allows all three packages to support Node 20+. - Remove `{ name }` option from AsyncLocalStorage constructor - Lower @types/node from ^24.5.2 to ^20.19.34 - Change engines.node from >=24.8.0 to >=20.0.0 - Bump patch versions (drizzle 0.1.1, typeorm 0.0.2, mikroorm 0.0.2) Co-Authored-By: Claude Opus 4.6 --- .../packages/sqlcommenter-drizzle/package.json | 6 +++--- .../packages/sqlcommenter-drizzle/src/als.ts | 4 +--- .../packages/sqlcommenter-mikroorm/package.json | 6 +++--- .../packages/sqlcommenter-mikroorm/src/als.ts | 4 +--- .../packages/sqlcommenter-typeorm/package.json | 6 +++--- .../packages/sqlcommenter-typeorm/src/als.ts | 4 +--- 6 files changed, 12 insertions(+), 18 deletions(-) diff --git a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/package.json b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/package.json index 54d9fefd..f1bf016f 100644 --- a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/package.json +++ b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/package.json @@ -1,6 +1,6 @@ { "name": "@query-doctor/sqlcommenter-drizzle", - "version": "0.1.0", + "version": "0.1.1", "description": "SQLCommenter patch for drizzle-orm", "main": "dist/cjs/index.js", "type": "module", @@ -32,7 +32,7 @@ }, "devDependencies": { "@electric-sql/pglite": "^0.3.10", - "@types/node": "^24.5.2", + "@types/node": "^20.19.34", "hono": "^4.9.8", "postgres": "^3.4.7", "rewiremock": "^3.14.3", @@ -47,7 +47,7 @@ "drizzle-orm": ">=0.35.0" }, "engines": { - "node": ">=24.8.0" + "node": ">=20.0.0" }, "scripts": { "test": "node --import=tsx --test test/**/*.spec.ts", diff --git a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/src/als.ts b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/src/als.ts index 6a0055b5..225da800 100644 --- a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/src/als.ts +++ b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/src/als.ts @@ -1,6 +1,4 @@ import { AsyncLocalStorage } from "node:async_hooks"; import type { RequestContext } from "./request-context.js"; -export const als = new AsyncLocalStorage({ - name: "request-context", -}); +export const als = new AsyncLocalStorage(); diff --git a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/package.json b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/package.json index bc120740..4e081d93 100644 --- a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/package.json +++ b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/package.json @@ -1,6 +1,6 @@ { "name": "@query-doctor/sqlcommenter-mikroorm", - "version": "0.0.1", + "version": "0.0.2", "description": "SQLCommenter patch for MikroORM", "main": "dist/cjs/index.js", "type": "module", @@ -32,7 +32,7 @@ }, "devDependencies": { "@mikro-orm/better-sqlite": "^6.6.7", - "@types/node": "^24.5.2", + "@types/node": "^20.19.34", "better-sqlite3": "^12.6.2", "tsx": "^4.20.5", "typescript": "^5.9.3" @@ -45,7 +45,7 @@ "@opentelemetry/core": ">=1.0.0" }, "engines": { - "node": ">=24.8.0" + "node": ">=20.0.0" }, "scripts": { "test": "node --import=tsx --test test/**/*.spec.ts", diff --git a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/src/als.ts b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/src/als.ts index 6a0055b5..225da800 100644 --- a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/src/als.ts +++ b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/src/als.ts @@ -1,6 +1,4 @@ import { AsyncLocalStorage } from "node:async_hooks"; import type { RequestContext } from "./request-context.js"; -export const als = new AsyncLocalStorage({ - name: "request-context", -}); +export const als = new AsyncLocalStorage(); diff --git a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/package.json b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/package.json index b61361f4..a441b544 100644 --- a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/package.json +++ b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/package.json @@ -1,6 +1,6 @@ { "name": "@query-doctor/sqlcommenter-typeorm", - "version": "0.0.1", + "version": "0.0.2", "description": "SQLCommenter patch for TypeORM", "main": "dist/cjs/index.js", "type": "module", @@ -32,7 +32,7 @@ } }, "devDependencies": { - "@types/node": "^24.5.2", + "@types/node": "^20.19.34", "reflect-metadata": "^0.2.2", "sql.js": "^1.12.0", "tsx": "^4.20.5", @@ -46,7 +46,7 @@ "typeorm": ">=0.3.0" }, "engines": { - "node": ">=24.8.0" + "node": ">=20.0.0" }, "scripts": { "test": "node --import=tsx --test test/**/*.spec.ts", diff --git a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/src/als.ts b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/src/als.ts index 6a0055b5..225da800 100644 --- a/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/src/als.ts +++ b/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/src/als.ts @@ -1,6 +1,4 @@ import { AsyncLocalStorage } from "node:async_hooks"; import type { RequestContext } from "./request-context.js"; -export const als = new AsyncLocalStorage({ - name: "request-context", -}); +export const als = new AsyncLocalStorage();