From e2bfb102b9ab636e9f37758ac68a2958a1ee42f2 Mon Sep 17 00:00:00 2001 From: Ryan Bahan Date: Fri, 27 Feb 2026 19:06:33 -0700 Subject: [PATCH] Migrate webhook_subscription spec to direct transform parameters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace transformConfig wrapper with deployConfig, transformLocalToRemote, and transformRemoteToLocal set directly. No behavior change — forward transform (URI resolution) and reverse transform preserved as-is. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../app_config_webhook_subscription.ts | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/app/src/cli/models/extensions/specifications/app_config_webhook_subscription.ts b/packages/app/src/cli/models/extensions/specifications/app_config_webhook_subscription.ts index 762c33eea86..c3689a95f43 100644 --- a/packages/app/src/cli/models/extensions/specifications/app_config_webhook_subscription.ts +++ b/packages/app/src/cli/models/extensions/specifications/app_config_webhook_subscription.ts @@ -1,7 +1,7 @@ import {WebhookSubscriptionUriValidation, removeTrailingSlash} from './validation/common.js' import {prependApplicationUrl} from './validation/url_prepender.js' import {WebhookSubscription} from './types/app_config_webhook.js' -import {CustomTransformationConfig, createConfigExtensionSpecification} from '../specification.js' +import {createConfigExtensionSpecification} from '../specification.js' import {CurrentAppConfiguration} from '../../app/app.js' import {zod} from '@shopify/cli-kit/node/schema' @@ -54,8 +54,10 @@ function transformToWebhookSubscriptionConfig(content: object) { } } -const WebhookSubscriptionTransformConfig: CustomTransformationConfig = { - forward: (content, appConfiguration) => { +const appWebhookSubscriptionSpec = createConfigExtensionSpecification({ + identifier: WebhookSubscriptionSpecIdentifier, + schema: SingleWebhookSubscriptionSchema, + transformLocalToRemote: (content, appConfiguration) => { const webhookConfig = content as WebhookSubscription let appUrl: string | undefined if ('application_url' in appConfiguration) { @@ -66,13 +68,7 @@ const WebhookSubscriptionTransformConfig: CustomTransformationConfig = { uri: prependApplicationUrl(webhookConfig.uri, appUrl), } }, - reverse: transformToWebhookSubscriptionConfig, -} - -const appWebhookSubscriptionSpec = createConfigExtensionSpecification({ - identifier: WebhookSubscriptionSpecIdentifier, - schema: SingleWebhookSubscriptionSchema, - transformConfig: WebhookSubscriptionTransformConfig, + transformRemoteToLocal: transformToWebhookSubscriptionConfig, uidStrategy: 'dynamic', })