fix(): Use a reducer to get the latest version

Modify how `reqcheck vcpkg` determines the latest version. Use a reducer that accumulates the latest version released for the library.

Remove the duplicate tag code since its redundant now.

Author: donny-dont

cmd/reqcheck/vcpkg.go

@@ -15,6 +15,7 @@ import (
 
 	"github.com/Masterminds/semver"
 	"github.com/WebKitForWindows/reqcheck"
+	"github.com/reactivex/rxgo/v2"
 	"github.com/sirupsen/logrus"
 	"github.com/urfave/cli/v2"
 	"gopkg.in/yaml.v3"
@@ -134,26 +135,21 @@ func vcpkgCmd() *cli.Command {
 					LimitTo: library.LimitTo,
 				}
 
-				releases, err := reqcheck.
-					ListReleases(scm, releaseOpts).
-					Filter(reqcheck.FilterRepeatVersions()).
+				latestRelease, err := reqcheck.ListReleases(scm, releaseOpts).
 					Filter(reqcheck.FilterSemanticConstraint(constraint)).
-					ToSlice(1)
-				if err != nil {
+					Reduce(reqcheck.ReduceGreatestVersion).
+					Get()
+				if err != nil || latestRelease == rxgo.OptionalSingleEmpty {
 					return fmt.Errorf("could not get releases %w", err)
 				}
 
-				if len(releases) == 0 {
-					return fmt.Errorf("could not find any releases for %s: %w", name, ErrCli)
-				}
-
 				release := releaseUpdate{
 					Name:    name,
 					Current: version,
-					Upgrade: releases[0].(reqcheck.Release).SemVer.String(),
+					Upgrade: latestRelease.V.(reqcheck.Release).SemVer.String(),
 				}
 
-				if len(releases) == 1 {
+				if release.Current == release.Upgrade {
 					current = append(current, release)
 				} else {
 					upgrade = append(upgrade, release)

filter.go

@@ -4,11 +4,7 @@
 
 package reqcheck
 
-import (
-	"slices"
-
-	"github.com/Masterminds/semver"
-)
+import "github.com/Masterminds/semver"
 
 func FilterSemanticVersion(item interface{}) bool {
 	release := item.(Release)
@@ -25,25 +21,6 @@ func FilterStableRelease(item interface{}) bool {
 	return release.SemVer.Prerelease() == ""
 }
 
-func FilterRepeatVersions() func(interface{}) bool {
-	seen := make([]string, 0)
-	return func(item interface{}) bool {
-		release := item.(Release)
-		if release.SemVer == nil {
-			return true
-		}
-
-		versionString := release.SemVer.String()
-
-		if slices.Contains(seen, versionString) {
-			return false
-		}
-
-		seen = append(seen, versionString)
-		return true
-	}
-}
-
 func FilterSemanticConstraint(c *semver.Constraints) func(interface{}) bool {
 	return func(item interface{}) bool {
 		release := item.(Release)

reduce.go

@@ -0,0 +1,29 @@
+// Copyright (c) 2024, the WebKit for Windows project authors.  Please see the
+// AUTHORS file for details. All rights reserved. Use of this source code is
+// governed by a BSD-style license that can be found in the LICENSE file.
+
+package reqcheck
+
+import "context"
+
+func ReduceGreatestVersion(_ context.Context, acc interface{}, elem interface{}) (interface{}, error) {
+	if acc == nil {
+		return elem, nil
+	}
+
+	accRelease := acc.(Release)
+	if accRelease.SemVer == nil {
+		return elem, nil
+	}
+
+	elemRelease := elem.(Release)
+	if elemRelease.SemVer == nil {
+		return acc, nil
+	}
+
+	if accRelease.SemVer.GreaterThan(elemRelease.SemVer) {
+		return acc, nil
+	}
+
+	return elem, nil
+}