Cleanup code

Author: bemain

lib/frontpage/about_section.dart

@@ -46,9 +46,8 @@ class AboutMeSection extends StatelessWidget {
   Widget build(BuildContext context) {
     final WindowSize windowSize = WindowSize.of(context);
 
-    return Container(
+    return Padding(
       padding: windowSize.margin.add(EdgeInsets.symmetric(vertical: 32)),
-      color: Theme.of(context).colorScheme.surfaceContainer,
       child: _buildBody(context),
     );
   }

lib/frontpage/contact_section.dart

@@ -42,15 +42,12 @@ class ContactSection extends StatelessWidget {
   Widget build(BuildContext context) {
     final WindowSize windowSize = WindowSize.of(context);
 
-    return Container(
-      color: Theme.of(context).colorScheme.surfaceContainer,
-      child: Padding(
-        padding: windowSize.margin.add(EdgeInsets.only(
-          top: 32,
-          bottom: 24,
-        )),
-        child: _buildContent(context),
-      ),
+    return Padding(
+      padding: windowSize.margin.add(EdgeInsets.only(
+        top: 32,
+        bottom: 24,
+      )),
+      child: _buildContent(context),
     );
   }
 

lib/frontpage/design_principles_section.dart

@@ -51,13 +51,14 @@ class DesignPrinciplesSection extends StatelessWidget {
   Widget _buildBody(BuildContext context) {
     switch (WindowSize.of(context)) {
       case WindowSize.compact:
+      case WindowSize.medium:
         return Column(
           mainAxisAlignment: MainAxisAlignment.spaceAround,
           crossAxisAlignment: CrossAxisAlignment.stretch,
           spacing: 12,
           children: [
             _buildTitle(context),
-            const SizedBox(height: 24),
+            const SizedBox(height: 0), // Resolves to 24px due to spacing
             for (final principle in designPrinciples)
               _buildPrinciple(context, principle),
           ],

lib/frontpage/frontpage.dart

@@ -71,11 +71,7 @@ class _FrontpageState extends State<Frontpage> {
       duration: Duration(milliseconds: 400),
       curve: Curves.easeInOut,
     );
-  }
-
-  Future<void> _onDestinationSelected(BuildContext context, int index) async {
-    await scrollTo(sectionKeys[index]);
-    selectedDestinationIndex.value = index;
+    selectedDestinationIndex.value = sectionKeys.indexOf(key);
   }
 
   @override
@@ -107,11 +103,17 @@ class _FrontpageState extends State<Frontpage> {
                   },
                 ),
               ),
-              AboutMeSection(key: aboutMeSectionKey),
+              Container(
+                color: Theme.of(context).colorScheme.surfaceContainer,
+                child: AboutMeSection(key: aboutMeSectionKey),
+              ),
               DesignPrinciplesSection(),
               TimelineSection(key: timelineSectionKey),
               ProjectsSection(key: projectsSectionKey),
-              ContactSection(key: contactSectionKey),
+              Container(
+                color: Theme.of(context).colorScheme.surfaceContainer,
+                child: ContactSection(key: contactSectionKey),
+              ),
             ],
           ),
         ),
@@ -185,10 +187,7 @@ class _FrontpageState extends State<Frontpage> {
 
         return TextButton.icon(
           onPressed: () {
-            _onDestinationSelected(
-              context,
-              Frontpage.destinations.indexOf(destination),
-            );
+            scrollTo(sectionKeys[Frontpage.destinations.indexOf(destination)]);
           },
           style: TextButton.styleFrom(
             padding: padding,
@@ -209,8 +208,8 @@ class _FrontpageState extends State<Frontpage> {
           builder: (context, selectedIndex, child) {
             return NavigationDrawer(
               selectedIndex: selectedDestinationIndex.value,
-              onDestinationSelected: (value) {
-                _onDestinationSelected(context, value);
+              onDestinationSelected: (index) {
+                scrollTo(sectionKeys[index]);
                 scaffoldKey.currentState?.closeDrawer();
               },
               children: [

lib/frontpage/title_section.dart

@@ -49,26 +49,23 @@ class TitleSection extends StatelessWidget {
           Column(
             children: [
               Expanded(
-                child: ConstrainedBox(
-                  constraints: BoxConstraints(),
-                  child: Row(
-                    mainAxisAlignment: MainAxisAlignment.center,
-                    children: [
-                      Flexible(
-                        child: _buildButterfly(context),
-                      ),
-                      const SizedBox(width: 24),
-                      Column(
-                        mainAxisSize: MainAxisSize.min,
-                        children: <Widget>[
-                          _buildTitle(context),
-                          _buildSubtitle(context),
-                          const SizedBox(height: 32),
-                          _buildContactButton(context),
-                        ],
-                      ),
-                    ],
-                  ),
+                child: Row(
+                  mainAxisAlignment: MainAxisAlignment.center,
+                  children: [
+                    Flexible(
+                      child: _buildButterfly(context),
+                    ),
+                    const SizedBox(width: 24),
+                    Column(
+                      mainAxisSize: MainAxisSize.min,
+                      children: <Widget>[
+                        _buildTitle(context),
+                        _buildSubtitle(context),
+                        const SizedBox(height: 32),
+                        _buildContactButton(context),
+                      ],
+                    ),
+                  ],
                 ),
               ),
               _buildDownArrow(context),