Skip to content

Favourite Feature added#64

Closed
GauravKarakoti wants to merge 3 commits intobetterbugs:developfrom
GauravKarakoti:Favourite
Closed

Favourite Feature added#64
GauravKarakoti wants to merge 3 commits intobetterbugs:developfrom
GauravKarakoti:Favourite

Conversation

@GauravKarakoti
Copy link

@GauravKarakoti GauravKarakoti commented Mar 3, 2026

Description

Added a favourite tool feature.
Favourite tools are pushed to top.
Added a filter for favourite tools.

Fixes #61

Screenshots of relevant screens

Screen.Recording.2026-03-03.112937.mp4

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the Coding Guidelines
  • My changes in code generate no new warnings
  • My changes are not breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

@rishima17 rishima17 changed the base branch from main to develop March 3, 2026 08:12
@rishima17 rishima17 requested a review from SyedFahad7 March 3, 2026 08:12
@rishima17 rishima17 added enhancement New feature or request apertre3.0 labels Mar 3, 2026
@SyedFahad7
Copy link
Collaborator

Please rebase your PR branch onto the latest develop (do not merge develop into your feature branch).

Try:

git fetch upstream
git rebase upstream/develop

Resolve conflicts and run local checks (npm run lint, npm run build)
git push --force-with-lease origin <your-branch>

Notes:
No need to fix unrelated pre-existing warnings.
Do fix errors introduced by your PR (especially in touched files).
This rebases only your PR branch; it does not rewrite our develop branch.

@GauravKarakoti
Copy link
Author

Done

Copy link
Collaborator

@SyedFahad7 SyedFahad7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauravKarakoti
Add try/catch around localStorage, so JSON parsing to handle invalid/corrupted stored data safely.

Prefer using tool url as the favorite identifier instead of title to avoid key collisions.

Add an aria-label on the star toggle button for accessibility.

@GauravKarakoti
Copy link
Author

Done

@rishima17 rishima17 added the easy label Mar 5, 2026
@SyedFahad7 SyedFahad7 self-requested a review March 6, 2026 10:11
@SyedFahad7
Copy link
Collaborator

Thanks @GauravKarakoti , the requested fixes are implemented: localStorage parse safety, URL-based favorite keying, and aria-label on the star toggle.

One process issue remains:
This branch includes a merge commit from develop (a877006). Please rebase onto latest develop and force-push with --force-with-lease (no merge commit).
Also please drop unrelated package-lock.json changes unless there is an intentional dependency update.

I suggest to raise a fresh PR so its easy to re-review and safely merge to develop!

Closing this PR for now :)

@SyedFahad7 SyedFahad7 closed this Mar 6, 2026
@GauravKarakoti GauravKarakoti deleted the Favourite branch March 6, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apertre3.0 easy enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Favorite tool feature

3 participants