From 215009f1930fc1da7e7499ee6fe948d5fb98cea1 Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Sat, 3 Jan 2026 20:07:34 +0000 Subject: [PATCH 1/6] chore: bump actions and change to sha --- .github/workflows/publish.yml | 4 ++-- .github/workflows/test.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 54f2e2f..dba4fab 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -8,8 +8,8 @@ jobs: publish: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v6 - - uses: actions/setup-node@v6 + - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0 with: node-version: 25 registry-url: https://registry.npmjs.org/ diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 125db20..84a215d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,10 +15,10 @@ jobs: steps: - name: Git sources - uses: actions/checkout@v2 + uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - name: Use Deno Version ${{ matrix.deno-version }} - uses: denoland/setup-deno@v1.1.0 + uses: denoland/setup-deno@e95548e56dfa95d4e1a28d6f422fafe75c4c26fb # v2.0.3 with: deno-version: ${{ matrix.deno-version }} From 30abc706ce4243e96dcaf6cdf7c9ed9dfcbd408d Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Sat, 3 Jan 2026 20:15:32 +0000 Subject: [PATCH 2/6] chore: fix deno errors --- mod.ts | 4 ++-- mod_test.ts | 2 +- package-lock.json | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/mod.ts b/mod.ts index 04d6df0..4b5b780 100644 --- a/mod.ts +++ b/mod.ts @@ -10,7 +10,7 @@ const canElideFrames = "captureStackTrace" in Error; export class AssertionError extends Error implements Result { [key: string]: unknown - get name(): "AssertionError" { + override get name(): "AssertionError" { return "AssertionError"; } @@ -19,7 +19,7 @@ export class AssertionError extends Error implements Result { } constructor( - public message = "Unspecified AssertionError", + public override message = "Unspecified AssertionError", props?: T, // deno-lint-ignore ban-types ssf?: Function, diff --git a/mod_test.ts b/mod_test.ts index 098096a..2da6fc2 100644 --- a/mod_test.ts +++ b/mod_test.ts @@ -38,7 +38,7 @@ test("AssertionError stack elides ssf if provided", function () { try { foo(); } catch (e) { - assert(e.stack.includes("foo") === false); + assert((e as Error).stack?.includes("foo") === false); } }); diff --git a/package-lock.json b/package-lock.json index e4f50e1..03b17b2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5,6 +5,7 @@ "requires": true, "packages": { "": { + "name": "assertion-error", "version": "0.0.0-dev", "license": "MIT", "engines": { From d61eb38c1f803d097b4ba50bdaafb48d457a1f57 Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Sat, 3 Jan 2026 20:16:09 +0000 Subject: [PATCH 3/6] chore: run format --- .github/workflows/test.yml | 2 +- .travis.yml | 1 - index.d.ts | 4 ++-- mod.ts | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 84a215d..f5fee08 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -37,6 +37,6 @@ jobs: # TODO: coverage broken see https://github.com/denoland/deno/issues/11875 # - name: Generate lcov # run: deno coverage coverage --lcov > coverage/lcov.info - + # - name: Assert coverage is good # uses: VeryGoodOpenSource/very_good_coverage@v1.2.0 diff --git a/.travis.yml b/.travis.yml index c44380c..787605c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,4 +11,3 @@ deploy: tags: true repo: chaijs/assertion-error all_branches: true - diff --git a/index.d.ts b/index.d.ts index d8fda2c..296a8fd 100644 --- a/index.d.ts +++ b/index.d.ts @@ -5,7 +5,7 @@ interface Result { } declare class AssertionError extends Error implements Result { - [key: string]: unknown + [key: string]: unknown; name: "AssertionError"; ok: false; message: string; @@ -16,7 +16,7 @@ declare class AssertionError extends Error implements Result { } declare class AssertionResult implements Result { - [key: string]: unknown + [key: string]: unknown; name: "AssertionResult"; ok: true; message: string; diff --git a/mod.ts b/mod.ts index 4b5b780..c437cf1 100644 --- a/mod.ts +++ b/mod.ts @@ -8,7 +8,7 @@ type V8Error = ErrorConstructor & { const canElideFrames = "captureStackTrace" in Error; export class AssertionError extends Error implements Result { - [key: string]: unknown + [key: string]: unknown; override get name(): "AssertionError" { return "AssertionError"; @@ -52,7 +52,7 @@ export class AssertionError extends Error implements Result { } export class AssertionResult implements Result { - [key: string]: unknown + [key: string]: unknown; get name(): "AssertionResult" { return "AssertionResult"; From 53280ba25a043f5779122280e1c17704096109cb Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Sat, 3 Jan 2026 20:19:15 +0000 Subject: [PATCH 4/6] chore: add format/lint scripts --- package.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package.json b/package.json index 235e1c8..62e4a8e 100644 --- a/package.json +++ b/package.json @@ -23,6 +23,8 @@ "main": "index.js", "scripts": { "build": "deno bundle mod.ts > index.js", + "format": "deno fmt", + "lint": "deno lint", "pretest": "rm -rf coverage/", "test": "deno test --coverage=coverage" } From 6269266ea60f1ccc3bf1e8962156e1eca984322f Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Sat, 3 Jan 2026 20:21:50 +0000 Subject: [PATCH 5/6] chore: bump deno --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f5fee08..fabc684 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - deno-version: [1.15.2, canary] + deno-version: [2.6.3, canary] steps: - name: Git sources From 78231299f8f92457931f6614618f9591ac9c76f0 Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Sat, 3 Jan 2026 20:31:11 +0000 Subject: [PATCH 6/6] chore: add deno.json --- deno.json | 5 +++++ mod_test.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 deno.json diff --git a/deno.json b/deno.json new file mode 100644 index 0000000..2960f6a --- /dev/null +++ b/deno.json @@ -0,0 +1,5 @@ +{ + "imports": { + "@std/assert": "jsr:@std/assert@^1.0.16" + } +} diff --git a/mod_test.ts b/mod_test.ts index 2da6fc2..86ce4ff 100644 --- a/mod_test.ts +++ b/mod_test.ts @@ -3,7 +3,7 @@ */ import { AssertionError, AssertionResult } from "./mod.ts"; -import { assert } from "https://deno.land/std@0.112.0/testing/asserts.ts"; +import { assert } from "@std/assert"; const { test } = Deno; test("AssertionError construction", () => {