-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathNOTES
More file actions
284 lines (189 loc) · 9.04 KB
/
NOTES
File metadata and controls
284 lines (189 loc) · 9.04 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
AFTERMATH
?document inversion bug?
moved trail files into lambda to remove strange cyclic dependency
renamed <directory>/<directory>.cm files to sources.cm
renamed Printer and PRINTER (in all combinations) to Print and PRINT
renamed Compiler and COMPILER to Compile and COMPILE to avoid
shadowing SMLofNJ top-level structures.
fixed bug for handling certain type ascriptions
fixed bug in parsing EVars under abstractions in evars.fun and frontend.fun
fixed space leak in trail.
integrate "targetType"? DONE => targetFamOpt and targetFam
compilation is not done incrementally (but: compileConfig, compile, top)
timing for queries/success continuation printing and waiting counts into solving!
CPrint is currently not used => correct?
please stick to naming conventions in the datatype definitions
(changed in opsem)
please do not curry functions without good reason
uncurried solver and printer.
CODE REVIEW, DECEMBER 1997 -fp
The constraint invariant was violated and does not seem fixable.
So...updated the invariant and the code throughout. Constraints
can not be printed except in terms of the variable involved. This
might be fixed later, when constraints are recorded in their
proper context.
printing of EVar's needs some consideration.
printing constraints for queries??
The variable tables are potential space leaks. For now, added the
context information to the list of EVar's with names, so that
constraints can be printed reliably. If we only had EVars with their
context! New scheme: go through the list of all named evars, and
collect constraints on the uninstantiated ones. These can then be
printed.
Todo here: fix top-level printer, including constraints.
In future, Tools should be a global structure and not passed
into functors.
TARGETFAM in names, index, and elsewhere---consolidate into IntSyn.
index/index.fun FIX TARGETTYPE TO AVOID WHNF?
Is there a termination checker? -NO
Move strictness into frontend directory. fix bug...
ctxLookup has changed! Now call ctxDec...
IntSyn.Ctx => IntSyn.Dcl IntSyn.Ctx (= IntSyn.DCtx except for MLWorks bug)
fix and/or document CQ
typecheck/typecheck.fun error message needs to be fixed
expressions should be U (terms from any level), not E
evars should be X
constraints.fun is buggy, missing invariants, "substitution"?
Are Abstract.collectExp and Abstract.printColl still used? -NO
======================================================================
Mon Jun 16 15:34:17 1997 -cs
Timers for whnf (lazy version) 3 runs of the compile example
- Timers.show ();
Parsing : Real = 5.469, Run = 3.338 (2.187 usr + 0.212 sys + 0.938 gc)
Reconstruction: Real = 5.278, Run = 2.836 (2.476 usr + 0.074 sys + 0.285 gc)
Abstraction : Real = 4.864, Run = 2.514 (1.949 usr + 0.092 sys + 0.472 gc)
Checking : Real = 0.000, Run = 0.000 (0.000 usr + 0.000 sys + 0.000 gc)
Modes : Real = 0.476, Run = 0.172 (0.147 usr + 0.025 sys + 0.000 gc)
Printing : Real = 7.077, Run = 4.175 (3.395 usr + 0.157 sys + 0.622 gc)
Total : Real = 23.166, Run = 13.037 (10.155 usr + 0.562 sys + 2.319 gc)
Timers for whnf (eager versions)
- Timers.show ();
Parsing : Real = 3.412, Run = 1.993 (1.601 usr + 0.092 sys + 0.299 gc)
Reconstruction: Real = 6.038, Run = 2.669 (2.443 usr + 0.039 sys + 0.186 gc)
Abstraction : Real = 3.831, Run = 1.748 (1.581 usr + 0.041 sys + 0.124 gc)
Checking : Real = 0.000, Run = 0.000 (0.000 usr + 0.000 sys + 0.000 gc)
Modes : Real = 0.845, Run = 0.162 (0.137 usr + 0.025 sys + 0.000 gc)
Printing : Real = 6.098, Run = 3.412 (3.041 usr + 0.079 sys + 0.291 gc)
Total : Real = 20.226, Run = 9.986 (8.805 usr + 0.278 sys + 0.902 gc)
val it = () : unit
Conclusion: Either the new code has a bug or its faster
Wed Jun 11 10:54:20 1997 -fp
Check frontend/timers and timing/
Tue Jun 10 09:01:28 1997 -fp
Improved error messages for fixity and name preferences
with locations.
Need to unify "IntSyn.name" vs "string" as types. PENDING
Are anonymous modes supported? NO---OK
Went through various parsing modules, improved and unified
error messages.
Mon Jun 9 14:52:33 1997 -fp
Went through parsing modules.
Introduced global/ directory and module Global : GLOBAL
with chatter : int ref and maxCid. DONE
Removed TpRecon.chatter. DONE
Renamed EXTINT to TP_RECON and EXTMODESINT to MODE_RECON. DONE
Parsing error should quote offending token. PENDING
Mon Jun 9 09:34:31 1997 -fp
Went through lexer, adding comments and invariants. DONE
Error recovery PENDING
Converting tokens to strings PENDING
NOTES Fri Jun 6 14:40:31 1997 -fp
Move getLevel from abstract.fun?
abstract.fun should use occurrences to give error messages.
NOTES Fri Jun 6 10:17:51 1997 -fp
Added comments to constraints, cleaned up invariants in
lambda, up to and including unify.fun.
NOTES Thu Jun 5 16:15:30 1997 -fp
Should establish a global structure for system parameters:
- chatter level
- size of constant table
Went through intsyn and whnf. Changed exception IntSyn.Sgn to
IntSyn.Error for consistency. DONE
NOTES Thu Jun 5 10:22:29 1997 -fp
Changed representation of Head to be either Exp or Idx (index) and
no longer an arbitrary constructor. Eliminated the dead code (which
can still be found in version 3.3). DONE
Renamed IntSyn.Abs to IntSyn.Lam for consistency. DONE
NOTES Mon Jun 2 12:05:39 1997
Need to add region support for definition, DONE
filenames to origin information. PENDING
NOTES Mon May 5 15:53:25 1997
Changed it so that quoted identifiers are simply quoted identifiers
but do not override infix status. This change is in the lexer only,
which now no longer produces "quoted" identifiers, except inside
pragmas. DONE
How to format EVars and FVars? Move into Names : NAMES? DONE
NOTES Fri Apr 25 20:50:26 1997
There is a bug in the formatter: if a fmtList end with Break, items will
be lost without warning (at least in an argument to HVbox). PENDING
Move the constant name hashtable from intsyn.fun to names.fun. DONE.
Must check that in/pre/postfix operator do no have too many or too few
explicit arguments for external printing. DONE.
Similarly, %named constants should be families, not objects. PENDING
Shadowing constants must also shadow fixity! DONE.
Global reset must reset fixity table, too, and name preferences. DONE
Quoted keywords (<-, ->, _, =, type) will print incorrectly.
So will items containing unprintable characters. Eliminate quoting?
DONE.
In printer.fun, uncurry functions for efficiency and stylistic
similarity to the rest of the code? PENDING
In Unify, we should try to resolve remaining constraints before
returning. This might be expensive, but necessary to get the right
operational behavior, I believe. Optimize by using flag to see if
constraints have been introduced/manipulated? PENDING
Identifiers starting with number, but not being numbers. DONE
Replaced P in invariants by W, since the result types of
spines are NOT guaranteed to be atomic. DONE
Rename relevance to strictness? DONE
Replaced C.S by C@S in invariants, since "." was too overloaded. DONE
intsyn:
Perhaps a Head should either be a BVar(n) or an expression.
Constants, definitions, and FVars complicate code, but do
not arise, as far as I can tell. DONE -fp Thu Jun 5 10:22:06 1997
General optimizations:
s = id
Compose substitutions eagerly instead of building closures
Introduced type Root = Con * Spine (not yet used). DONE
Similarly: type Closure = Exp * Sub (used in lambda) DONE
conv:
introduce function
expandShift (n) = Dot (Con (BVar(n+1), Shift(n+1)))
in IntSyn? PENDING
constraints: add invariants? DONE
======================================================================
COMMENTS:
2/27/97
In the previous implementation of MLF, constants were defined
as de Bruijn indices. This implementation had several problems
1) no direct head comparison possible, because
substitutions must be calculated first.
2) not suitable for an operational interpretation of the
system: For every constant lookup, a long
list must be traversed to find the type of a
constant.
Hence we decided to go with another idea of representing constants:
- A constant is an identifier which can be easily
tested for equality.
- An LF signature is just an array, the constant identifier can be
used to access information
- A hash function allows to determine a the constant
identifier from the constant string.
- This idea is consistent with the module idea.
+ signature doesn't change after parsing
+ Every module possess a own signature
Sun Mar 23 22:01:52 1997
Should we either (a) annotate pis on whether there is a dependency or
(b) have a separate constructor for non-dependent function type? The
operational semantics will need this distinction. Natural typing for
arrow:
G |- A : type G |- V : L
---------------------------
G |- A -> V : L
G, A |- U : V[^]
-----------------------
G |- [x:A] U : A -> V
If we introduce it, how and where do we annotate terms, and how do
we manipulate this annotation?
2/27/97: Optimize the representation of constants: constants c . nil should
be represented as just c.
03/08/97,fp: clean up and export exceptions.