From e9d86c2d549870713884fc5efc9ba3261e37e9ac Mon Sep 17 00:00:00 2001
From: IvanBorislavovDimitrov <starstrucks1997@gmail.com>
Date: Thu, 26 Feb 2026 14:46:18 +0200
Subject: [PATCH] Fix swagger-maven-plugin failing to generate FilesApi
 endpoints

The swagger-maven-plugin (v3.1.8) was skipping FilesApi.java during Swagger generation because it internally expects javax.servlet classes but the project uses Jakarta EE (jakarta.servlet). This caused all /api/v1/spaces/{spaceGuid}/files endpoints to be removed from mtarest.yaml on every build.
Added javax.servlet-api as a provided dependency to satisfy the plugin's internal class resolution.
---
 multiapps-controller-api/pom.xml                  |  6 ++++++
 .../src/main/resources/mtarest.yaml               | 15 +++++++++++++++
 pom.xml                                           |  9 +++++++++
 3 files changed, 30 insertions(+)

diff --git a/multiapps-controller-api/pom.xml b/multiapps-controller-api/pom.xml
index fbc5e96bb9..d369fa99a6 100644
--- a/multiapps-controller-api/pom.xml
+++ b/multiapps-controller-api/pom.xml
@@ -68,6 +68,12 @@
             <artifactId>jaxb-api</artifactId>
             <scope>provided</scope>
         </dependency>
+        <!-- Required by swagger-maven-plugin during compile to process MultipartHttpServletRequest -->
+        <dependency>
+            <groupId>javax.servlet</groupId>
+            <artifactId>javax.servlet-api</artifactId>
+            <scope>provided</scope>
+        </dependency>
     </dependencies>
 
     <build>
diff --git a/multiapps-controller-api/src/main/resources/mtarest.yaml b/multiapps-controller-api/src/main/resources/mtarest.yaml
index 2fa76ac907..8a6de8c701 100644
--- a/multiapps-controller-api/src/main/resources/mtarest.yaml
+++ b/multiapps-controller-api/src/main/resources/mtarest.yaml
@@ -426,6 +426,9 @@ definitions:
       mta_id:
         type: "string"
         readOnly: true
+      schema_version:
+        type: "string"
+        readOnly: true
       client_actions:
         type: "array"
         readOnly: true
@@ -463,6 +466,9 @@ definitions:
       file_url:
         type: "string"
         readOnly: true
+      credentials:
+        readOnly: true
+        $ref: "#/definitions/UserCredentials"
   Info:
     type: "object"
     properties:
@@ -643,3 +649,12 @@ definitions:
       name:
         type: "string"
         readOnly: true
+  UserCredentials:
+    type: "object"
+    properties:
+      username:
+        type: "string"
+        readOnly: true
+      password:
+        type: "string"
+        readOnly: true
diff --git a/pom.xml b/pom.xml
index c4e1cd608e..61a06137fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,6 +60,7 @@
         <commons-logging.version>1.3.5</commons-logging.version>
         <google-cloud.version>2.62.1</google-cloud.version>
         <google-cloud-nio.version>0.128.11</google-cloud-nio.version>
+        <javax.servlet-api.version>4.0.1</javax.servlet-api.version>
     </properties>
     <modules>
         <module>multiapps-controller-client</module>
@@ -403,6 +404,14 @@
                 <version>${servlet-api.version}</version>
                 <scope>provided</scope>
             </dependency>
+            <!-- Required by swagger-maven-plugin during compile to process MultipartHttpServletRequest. Migrate once swagger plugin supports Jakarta namespace. -->
+            <!-- https://mvnrepository.com/artifact/javax.servlet/javax.servlet-api -->
+            <dependency>
+                <groupId>javax.servlet</groupId>
+                <artifactId>javax.servlet-api</artifactId>
+                <version>${javax.servlet-api.version}</version>
+                <scope>provided</scope>
+            </dependency>
             <!-- https://mvnrepository.com/artifact/jakarta.annotation/jakarta.annotation-api -->
             <dependency>
                 <groupId>jakarta.annotation</groupId>