Ripasso claims (incorrectly) there are passwords not in version control

[alfredolito]

Ripasso won't start, but prints this error message:

user@MacBook-Pro debug % ./ripasso-cursive
The password store is backed by a git repository, but there is passwords there that's not in git. Please add them, otherwise they might get lost.

However, when doing git status in ~/.password-store, there is nothing not in version control, and the branch is in sync with origin:

user@MacBook-Pro .password-store % git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

• The PASSWORD_STORE_DIR environment variable is not set.
• Setting PASSWORD_STORE_DIR="$HOME/.password-store/" does not help.
• All files in ~/.password-store is owned by me, with full read and write permissions.

I compiled ripasso on latest commit (eb4ceffcb6e1f237e8ed0e24cb97b593b34b196e).
Also tried going back to a commit from october 2024 (2fe100882d77d38fab39c9911d56086c6da797a8), with same result.

[alfredolito]

I added a println!("{}", not_found.display()); where the RepositoryStatus::NotInRepo is set in src/pass.rs:

        // If there are any files we couldn't find, add them to the list anyway
        for not_found in files_to_find {
            println!("{}", not_found.display());
            passwords.push(PasswordEntry::new(
                &self.root,
                &not_found.clone(),
                Err(Error::Generic("")),
                Err(Error::Generic("")),
                Err(Error::Generic("")),
                RepositoryStatus::NotInRepo,
            ));
        }

Turns out that all files that gets this status has Swedish national chars (å, ä or ö) in the filename.

I'm on a Apple M1 with MacOS 14.7.5 with an APFS filesystem.

[alexanderkjall]

This sounds like it should we relatively easy to write a unit test for, I'll start with that.

How to fix it is another problem that will require some research.

[alexanderkjall]

@alfredolito do this unit test reproduce the issue for you? #386

[alfredolito]

Your test is is successful.

However, when I create a different test file with nordic file names (I put it here #387), I get this:

So there is a difference in the binary representation of å, Å, ä, Ä, ö and Ö, while æ, Æ, ø and Ø are the same. So, I guess some kind of unicode normalization (google "NFC vs NFD") is needed.

[alfredolito]

I'm guessing core.precomposeUnicode=true in git might have some effect here, since I guess the issue occurs when the binary representation is not the same in git and in the filesystem.

[alexanderkjall]

Seems like this is the documentation for that: https://git-scm.com/docs/git-config/2.14.6#Documentation/git-config.txt-coreprecomposeUnicode

And there is something about it in libgit2 here: https://github.com/libgit2/libgit2/blob/main/src/libgit2/repository.h#L51

But there doesn't seem to be any rust bindings: https://github.com/search?q=repo%3Arust-lang%2Fgit2-rs+precompose&type=code