use VerifyXml#15247
Draft
SimonCropp wants to merge 1 commit intomicrosoft:mainfrom
Draft
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15247Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15247" |
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Aspire CLI snapshot tests to use Verify’s dedicated XML verifier helper, improving XML snapshot handling consistency across the test suite.
Changes:
- Replace
Verify(..., extension: "xml")withVerifyXml(...)in project migration/update snapshots. - Replace
Verify(..., extension: "xml")withVerifyXml(...)in NuGet.config merger snapshot tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Cli.Tests/Projects/ProjectUpdaterTests.cs | Switches csproj snapshot assertions to VerifyXml for XML-specific verification. |
| tests/Aspire.Cli.Tests/Packaging/NuGetConfigMergerSnapshotTests.cs | Switches NuGet.config XML snapshot assertions to VerifyXml, preserving existing .UseFileName(...) usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.