chore(deps): bump latex2mathml from 3.78.0 to 3.78.1#5361
chore(deps): bump latex2mathml from 3.78.0 to 3.78.1#5361nucleogenesis merged 3 commits intounstablefrom
Conversation
dependabot
bot
added
dependencies
|
There's a small bug fix here that is causing a change in output - we'd need to update what are essentially snapshot tests for the latex to mathml conversion to be able to merge this PR. |
dependabot
bot
force-pushed
the
dependabot/pip/latex2mathml-3.78.1
branch
from
48b9b50 to
24de11e
Compare
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/pip/latex2mathml-3.78.1
branch
from
24de11e to
42a2641
Compare
Bumps [latex2mathml](https://github.com/roniemartinez/latex2mathml) from 3.78.0 to 3.78.1. - [Release notes](https://github.com/roniemartinez/latex2mathml/releases) - [Commits](roniemartinez/latex2mathml@3.78.0...3.78.1) --- updated-dependencies: - dependency-name: latex2mathml dependency-version: 3.78.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…erover latex2mathml 3.78.1 correctly produces <munderover> instead of <msubsup> for \sum and \prod in display="block" mode. Update hardcoded expected MathML in test assertions to match the corrected output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nucleogenesis
force-pushed
the
dependabot/pip/latex2mathml-3.78.1
branch
from
42a2641 to
4a9a5d6
Compare
rtibblesbot
left a comment
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency Update Review
Package: latex2mathml 3.78.0 → 3.78.1
Semver risk: Patch
Dependency type: Production
CI status: Passing
Changelog Analysis
Sources consulted:
Single bugfix release: "Fix block mode not using munderover" (roniemartinez/latex2mathml#529). In block/display mode, summation-like operators now correctly use <munderover> (limits above/below) instead of <msubsup> (subscript/superscript). This is the correct MathML representation for display-mode limits.
Breaking changes: None.
Security fixes: None.
Compatibility Assessment
- Output change: The MathML output for block-mode expressions with limits changes from
msubsuptomunderover. This is a correctness fix —munderoveris the semantically correct element for display-mode limits. - Test updates included: Both
test_exercise_creation.pyandtest_markdown.pyhave been updated to expect the newmunderoveroutput, matching the library's corrected behavior. - Prior context: Maintainer @rtibbles flagged the need for test updates, which have been addressed in commit
4a9a5d67c.
Recommendation
APPROVE — Patch bugfix with passing CI and correct test updates.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Reviewed the pull request diff checking for:
- Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
- Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
- Architecture: duplicated concerns, minimal interfaces, composition over inheritance
- Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
- Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
- Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
- Checked CI status and linked issue acceptance criteria
- For UI changes: inspected screenshots for layout, visual completeness, and consistency
|
I have manually regression tested that serialization of the potentially effected sum/prod. Looks like @rtibblesbot agrees with the assessment overall now that the tests are passing. @rtibbles one thing that Claude noted when reviewing this again today was that there are possible regressions in the QTI editor - here is a gist detailing their output |
Verify that latex2mathml produces the correct MathML elements: - \sum and \prod in block mode use <munderover> (limits above/below) - \sum in inline mode uses <msubsup> (limits beside) - \int in block mode still uses <msubsup> (unaffected by fix) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Alrighty - tested it out and verified the fixes by publishing and then testing QTI & Perseus questions in Kolibri and manually confirmed that the XML was appropriately updated. I also drew up and pushed some regression tests covering the particular markdown conversion changes introduced by the update. I can also doubly confirm the updates are good because:
The updates this PR brings makes it so that the XML uses proper under/above indicators, so you can see how the limit info is shown above/beneath the Σ properly now. |
nucleogenesis
left a comment
nucleogenesis
left a comment
There was a problem hiding this comment.
See previous comments - should have put the last comment in an approving review!
4 participants
Bumps latex2mathml from 3.78.0 to 3.78.1.
Release notes
Sourced from latex2mathml's releases.
Commits
d74fb4a⬆️ Bump version97dcf22⬆️ Bump pytest from 8.3.5 to 8.4.1 (#519)8c76a59Simplifyc1e4f17⬆️ Bump multidict from 6.4.4 to 6.6.4 (#527)4f29cf6⬆️ Bump mypy from 1.15.0 to 1.17.1 (#525)1f0dfecadd delfanbaum as a contributor for code, and test (#530)36b9376add cuppajoeman as a contributor for bug (#531)7fb5dcb⬆️ Bump codecov/codecov-action from 5.4.3 to 5.5.0 (#528)6578bf0⬆️ Bump actions/checkout from 4 to 5 (#526)f56ea64⬆️ Bump pytest-cov from 6.1.1 to 6.2.1 (#516)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)