Skip to content

[Bug] [chore] Files in UTF-8 w BOM / CRLF format were included. #1389

@masamaru-san

Description

@masamaru-san

Git commit

Current:
87ecb95 feat: add webp support (#1384)

commit from:
f16a110 refactor: migrate generation pipeline to sd::Tensor (#1373)

Operating System & Version

Windows 11 25H2

GGML backends

CPU

Command-line arguments used


Steps to reproduce

Do download files and check:

$ curl -O https://raw.githubusercontent.com/leejet/stable-diffusion.cpp/f16a110f8776398ef23a2a6b7b57522c2471637a/src/t5.hpp
  % Total    % Received % Xferd  Average Speed  Time    Time    Time   Current
                                 Dload  Upload  Total   Spent   Left   Speed
100  43444 100  43444   0      0 451.4k      0                              0

$ curl -O https://raw.githubusercontent.com/leejet/stable-diffusion.cpp/f16a110f8776398ef23a2a6b7b57522c2471637a/src/tokenize_util.cpp
  % Total    % Received % Xferd  Average Speed  Time    Time    Time   Current
                                 Dload  Upload  Total   Spent   Left   Speed
100  28547 100  28547   0      0  99399      0                              0

$ file ./t5.hpp
./t5.hpp: C++ source, Unicode text, UTF-8 (with BOM) text, with CRLF line terminators

$ file ./tokenize_util.cpp
./tokenize_util.cpp: C source, Unicode text, UTF-8 (with BOM) text, with CRLF line terminators

Or only see the changes view on the GitHub web UI.

What you expected to happen

All souces are UTF-8 without BOM and LF endings.

What actually happened

Current master (87ecb95) contains UTF-8-BOM / CRLF files.

Files:

  • src/t5.hpp
  • src/tokenize_util.cpp

Logs / error messages / stack trace

No response

Additional context / environment details

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions