diff --git a/lib/mcp/server/transports/streamable_http_transport.rb b/lib/mcp/server/transports/streamable_http_transport.rb index f1a5d9d..2b658ec 100644 --- a/lib/mcp/server/transports/streamable_http_transport.rb +++ b/lib/mcp/server/transports/streamable_http_transport.rb @@ -120,10 +120,14 @@ def handle_post(request) if body["method"] == "initialize" handle_initialization(body_string, body) - elsif notification?(body) || response?(body) - handle_accepted else - handle_regular_request(body_string, session_id) + return missing_session_id_response if !@stateless && !session_id + + if notification?(body) || response?(body) + handle_accepted + else + handle_regular_request(body_string, session_id) + end end rescue StandardError => e MCP.configuration.exception_reporter.call(e, { request: body_string }) diff --git a/test/mcp/server/transports/streamable_http_transport_test.rb b/test/mcp/server/transports/streamable_http_transport_test.rb index 4b346c4..94b6226 100644 --- a/test/mcp/server/transports/streamable_http_transport_test.rb +++ b/test/mcp/server/transports/streamable_http_transport_test.rb @@ -272,6 +272,62 @@ class StreamableHTTPTransportTest < ActiveSupport::TestCase assert_equal "Missing session ID", body["error"] end + test "rejects POST request without session ID in stateful mode" do + request = create_rack_request( + "POST", + "/", + { "CONTENT_TYPE" => "application/json" }, + { jsonrpc: "2.0", method: "ping", id: "1" }.to_json, + ) + + response = @transport.handle_request(request) + assert_equal 400, response[0] + body = JSON.parse(response[2][0]) + assert_equal "Missing session ID", body["error"] + end + + test "rejects notification without session ID in stateful mode" do + request = create_rack_request( + "POST", + "/", + { "CONTENT_TYPE" => "application/json" }, + { jsonrpc: "2.0", method: "notifications/initialized" }.to_json, + ) + + response = @transport.handle_request(request) + assert_equal 400, response[0] + body = JSON.parse(response[2][0]) + assert_equal "Missing session ID", body["error"] + end + + test "rejects response without session ID in stateful mode" do + request = create_rack_request( + "POST", + "/", + { "CONTENT_TYPE" => "application/json" }, + { jsonrpc: "2.0", id: "1", result: {} }.to_json, + ) + + response = @transport.handle_request(request) + assert_equal 400, response[0] + body = JSON.parse(response[2][0]) + assert_equal "Missing session ID", body["error"] + end + + test "allows POST request without session ID in stateless mode" do + stateless_transport = StreamableHTTPTransport.new(@server, stateless: true) + + request = create_rack_request( + "POST", + "/", + { "CONTENT_TYPE" => "application/json" }, + { jsonrpc: "2.0", method: "ping", id: "1" }.to_json, + ) + + response = stateless_transport.handle_request(request) + assert_equal 200, response[0] + end + test "rejects duplicate SSE connection with 409" do # Create a session init_request = create_rack_request(