Apply AI PR feedback

Change memoization level for ENSApi options object

Author: tk-o

apps/ensadmin/src/components/providers/selected-ensnode-provider.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import type { PropsWithChildren } from "react";
+import { type PropsWithChildren, useMemo } from "react";
 
 import { createEnsApiOptions, EnsApiProvider } from "@ensnode/ensnode-react";
 
@@ -21,9 +21,15 @@ export function SelectedEnsApiProvider({ children }: PropsWithChildren) {
   const selectedConnection = useSelectedConnection();
 
   if (selectedConnection.validatedSelectedConnection.isValid) {
-    const options = createEnsApiOptions({
-      url: selectedConnection.validatedSelectedConnection.url,
-    });
+    const selectedConenctionUrl = selectedConnection.validatedSelectedConnection.url;
+    const options = useMemo(
+      () =>
+        createEnsApiOptions({
+          url: selectedConenctionUrl,
+        }),
+      [selectedConenctionUrl],
+    );
+
     return <EnsApiProvider options={options}>{children}</EnsApiProvider>;
   } else {
     // TODO: Logic here needs a deeper refactor to recognize the difference

packages/ensnode-react/README.md

@@ -126,19 +126,19 @@ function DisplayPrimaryNames() {
 
 ### EnsApiProvider
 
-The provider component that supplies ENSNode configuration to all child components.
+The provider component that supplies ENSApi options to all child components.
 
 ```tsx
 interface EnsApiProviderProps {
-  config: ENSNodeConfig;
+  options: EnsApiProviderOptions;
   queryClient?: QueryClient;
   queryClientOptions?: QueryClientOptions;
 }
 ```
 
 #### Props
 
-- `config`: ENSNode configuration object
+- `options`: ENSApi options object
 - `queryClient`: Optional TanStack Query client instance (requires manual QueryClientProvider setup)
 - `queryClientOptions`: Optional Custom options for auto-created QueryClient (only used when queryClient is not provided)
 
@@ -235,7 +235,7 @@ The `EnsApiProvider` automatically creates and manages a QueryClient for you. Ca
 ```tsx
 // Simple setup - no TanStack Query knowledge needed
 <EnsApiProvider
-  config={config}
+  options={options}
   queryClientOptions={{
     defaultOptions: {
       queries: {
@@ -268,7 +268,7 @@ const queryClient = new QueryClient({
 });
 
 <QueryClientProvider client={queryClient}>
-  <EnsApiProvider config={config} queryClient={queryClient}>
+  <EnsApiProvider options={options} queryClient={queryClient}>
     <App />
   </EnsApiProvider>
 </QueryClientProvider>;

packages/ensnode-react/src/hooks/useResolvedIdentity.ts

@@ -23,7 +23,7 @@ import { usePrimaryName } from "./usePrimaryName";
  * @param parameters - Configuration object for the hook
  * @param parameters.identity - An {@link UnresolvedIdentity} containing the {@link DefaultableChainId}
  *                              and {@link Address} to resolve.
- * @param parameters.namespaceId - The {@link ENSNamespaceId} that `identity.chainId` should be interpreted
+ * @param parameters.namespace - The {@link ENSNamespaceId} that `identity.chainId` should be interpreted
  *                                 through (via {@link getResolvePrimaryNameChainIdParam}) to determine the literal
  *                                 chainId that should be used for ENSIP-19 primary name resolution.
  * @param parameters.accelerate - Whether to attempt Protocol Acceleration (default: false)

packages/ensnode-react/src/provider.tsx

@@ -33,10 +33,7 @@ function EnsApiInternalProvider({
   children?: React.ReactNode;
   options: EnsApiProviderOptions;
 }) {
-  // Memoize the options to prevent unnecessary re-renders
-  const memoizedOptions = useMemo(() => options, [options]);
-
-  return createElement(EnsApiContext.Provider, { value: memoizedOptions }, children);
+  return createElement(EnsApiContext.Provider, { value: options }, children);
 }
 
 export function EnsApiProvider(parameters: React.PropsWithChildren<EnsApiProviderProps>) {

packages/ensnode-react/src/types.ts

@@ -15,7 +15,7 @@ import type {
 } from "@ensnode/ensnode-sdk";
 
 /**
- * Configuration options for the ENSNode provider
+ * Configuration options for the ENSApi provider
  */
 export interface EnsApiProviderOptions {
   /** The ENSApi client configuration */