Apply AI PR feedback

Author: tk-o

apps/ensadmin/src/components/connection/cards/ensnode-info.tsx

@@ -345,7 +345,7 @@ function ENSNodeConfigCardContent({
               <p>
                 Version of the{" "}
                 <ExternalLinkWithIcon
-                  href={`https://www.npmjs.com/package/@adraffy/ens-normalize/v/${ensIndexerPublicConfig.versionInfo.ensNormalize}`}
+                  href={`https://www.npmjs.com/package/@adraffy/ens-normalize/v/${ensApiPublicConfig.versionInfo.ensNormalize}`}
                 >
                   @adraffy/ens-normalize
                 </ExternalLinkWithIcon>{" "}

apps/ensapi/src/config/validations.ts

@@ -45,13 +45,13 @@ export function invariant_ensIndexerPublicConfigVersionInfo(
     });
   }
 
-  // Invariant: `ens-normalize` package version must match between ENSApi & ENSIndexer
+  // Invariant: `@adraffy/ens-normalize` package version must match between ENSApi & ENSIndexer
   if (ensIndexerPublicConfig.versionInfo.ensNormalize !== ensApiVersionInfo.ensNormalize) {
     ctx.issues.push({
       code: "custom",
       path: ["ensIndexerPublicConfig.versionInfo.ensNormalize"],
       input: ensIndexerPublicConfig.versionInfo.ensNormalize,
-      message: `Dependency Version Mismatch: 'ens-normalize.js' version must be the same between ENSIndexer and ENSApi. Found ENSApi@${ensApiVersionInfo.ensNormalize} and ENSIndexer@${ensIndexerPublicConfig.versionInfo.ensNormalize}`,
+      message: `Dependency Version Mismatch: '@adraffy/ens-normalize' version must be the same between ENSIndexer and ENSApi. Found ENSApi@${ensApiVersionInfo.ensNormalize} and ENSIndexer@${ensIndexerPublicConfig.versionInfo.ensNormalize}`,
     });
   }
 }

apps/ensapi/src/lib/version-info.ts

@@ -19,10 +19,10 @@ function getEnsApiVersion(): string {
  * Note:
  * Since we use PNPM's `catalog:` references, reading directly from
  * the `package.json` file would give us `catalog:` values, and not resolved
- * version values. We need the later, so we implement our own version
+ * version values. We need the latter, so we implement our own version
  * resolution method.
  */
-function getPackageVersion(packageName: string) {
+function getPackageVersion(packageName: string): string {
   try {
     // Start from current file's directory
     const currentFile = fileURLToPath(import.meta.url);

packages/ensnode-sdk/src/ensapi/config/zod-schemas.ts

@@ -13,8 +13,8 @@ export { TheGraphCannotFallbackReasonSchema, TheGraphFallbackSchema };
 
 const makeEnsApiVersionInfoSchema = (valueLabel: string = "ENS API version info") =>
   z.object({
-    ensApi: z.string().min(1, `${valueLabel}.ensApi must be a non-empty string`),
-    ensNormalize: z.string().min(1, `${valueLabel}.ensNormalize must be a non-empty string`),
+    ensApi: z.string().nonempty(`${valueLabel}.ensApi must be a non-empty string`),
+    ensNormalize: z.string().nonempty(`${valueLabel}.ensNormalize must be a non-empty string`),
   });
 
 /**