Skip to content

Commit 7fca45d

Browse files
authored
Remove nodejs version info from data model (#1858)
1 parent 90eeaea commit 7fca45d

18 files changed

Lines changed: 9 additions & 65 deletions

File tree

.changeset/dry-pants-begin.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@ensnode/ensnode-sdk": minor
3+
---
4+
5+
Removed `nodejs` field from `EnsIndexerVersionInfo` data model.

apps/ensadmin/src/app/mock/config-api.mock.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export const ensIndexerPublicConfig = deserializeENSIndexerPublicConfig({
2727
"tokenscope",
2828
],
2929
versionInfo: {
30-
nodejs: "22.18.0",
3130
ponder: "0.11.43",
3231
ensIndexer: "0.35.0",
3332
ensDb: "0.35.0",

apps/ensadmin/src/components/connection/cards/ensnode-info.tsx

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -447,23 +447,6 @@ function ENSNodeConfigCardContent({
447447
</div>
448448
}
449449
/>
450-
<InfoCardItem
451-
label="Node.js"
452-
value={
453-
<p className={cardItemValueStyles}>{ensIndexerPublicConfig.versionInfo.nodejs}</p>
454-
}
455-
additionalInfo={
456-
<p>
457-
Version of the{" "}
458-
<ExternalLinkWithIcon
459-
href={`https://nodejs.org/en/download/archive/v${ensIndexerPublicConfig.versionInfo.nodejs}`}
460-
>
461-
Node.js
462-
</ExternalLinkWithIcon>{" "}
463-
runtime.
464-
</p>
465-
}
466-
/>
467450
<InfoCardItem
468451
label="Ponder"
469452
value={

apps/ensapi/src/config/config.schema.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ const ENSINDEXER_PUBLIC_CONFIG = {
4646
ensDb: packageJson.version,
4747
ensIndexer: packageJson.version,
4848
ensNormalize: "1.1.1",
49-
nodejs: "1.1.1",
5049
ponder: "1.1.1",
5150
},
5251
} satisfies ENSIndexerPublicConfig;

apps/ensindexer/src/lib/ensdb-writer-worker/ensdb-writer-worker.mock.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export const mockEnsRainbowPublicConfig: EnsRainbowPublicConfig = {
2727

2828
// Test fixture for EnsIndexerVersionInfo
2929
export const mockVersionInfo: EnsIndexerVersionInfo = {
30-
nodejs: "20.0.0",
3130
ponder: "0.9.0",
3231
ensDb: "1.0.0",
3332
ensIndexer: "1.0.0",

apps/ensindexer/src/lib/public-config-builder/public-config-builder.test.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ vi.mock("@/config", () => ({
2626
// Mock the version-info module
2727
vi.mock("@/lib/version-info", () => ({
2828
getEnsIndexerVersion: vi.fn(),
29-
getNodeJsVersion: vi.fn(),
3029
getPackageVersion: vi.fn(),
3130
}));
3231

@@ -48,7 +47,7 @@ import {
4847
validateEnsIndexerVersionInfo,
4948
} from "@ensnode/ensnode-sdk";
5049

51-
import { getEnsIndexerVersion, getNodeJsVersion, getPackageVersion } from "@/lib/version-info";
50+
import { getEnsIndexerVersion, getPackageVersion } from "@/lib/version-info";
5251

5352
// Test fixtures
5453
const mockEnsRainbowConfig: EnsRainbowPublicConfig = {
@@ -58,7 +57,6 @@ const mockEnsRainbowConfig: EnsRainbowPublicConfig = {
5857
};
5958

6059
const mockVersionInfo: EnsIndexerVersionInfo = {
61-
nodejs: "20.0.0",
6260
ponder: "0.9.0",
6361
ensDb: "1.0.0",
6462
ensIndexer: "1.0.0",
@@ -83,7 +81,6 @@ function createMockPublicConfig(overrides: Partial<EnsIndexerPublicConfig> = {})
8381
// Helper to setup standard mocks
8482
function setupStandardMocks() {
8583
vi.mocked(getEnsIndexerVersion).mockReturnValue("1.0.0");
86-
vi.mocked(getNodeJsVersion).mockReturnValue("20.0.0");
8784
vi.mocked(getPackageVersion).mockReturnValue("0.9.0");
8885
vi.mocked(validateEnsIndexerVersionInfo).mockReturnValue(mockVersionInfo);
8986
}
@@ -112,12 +109,10 @@ describe("PublicConfigBuilder", () => {
112109
// Assert
113110
expect(ensRainbowClientMock.config).toHaveBeenCalledTimes(1);
114111
expect(getEnsIndexerVersion).toHaveBeenCalledTimes(1);
115-
expect(getNodeJsVersion).toHaveBeenCalledTimes(1);
116112
expect(getPackageVersion).toHaveBeenCalledWith("ponder");
117113
expect(getPackageVersion).toHaveBeenCalledWith("@adraffy/ens-normalize");
118114

119115
expect(validateEnsIndexerVersionInfo).toHaveBeenCalledWith({
120-
nodejs: "20.0.0",
121116
ponder: "0.9.0",
122117
ensDb: "1.0.0",
123118
ensIndexer: "1.0.0",
@@ -158,7 +153,6 @@ describe("PublicConfigBuilder", () => {
158153
// Assert
159154
expect(ensRainbowClientMock.config).toHaveBeenCalledTimes(1);
160155
expect(getEnsIndexerVersion).toHaveBeenCalledTimes(1);
161-
expect(getNodeJsVersion).toHaveBeenCalledTimes(1);
162156
expect(getPackageVersion).toHaveBeenCalledTimes(2);
163157
expect(validateEnsIndexerVersionInfo).toHaveBeenCalledTimes(1);
164158
expect(validateEnsIndexerPublicConfig).toHaveBeenCalledTimes(1);
@@ -183,11 +177,9 @@ describe("PublicConfigBuilder", () => {
183177
} as unknown as EnsRainbow.ApiClient;
184178

185179
vi.mocked(getEnsIndexerVersion).mockReturnValue("2.0.0");
186-
vi.mocked(getNodeJsVersion).mockReturnValue("22.0.0");
187180
vi.mocked(getPackageVersion).mockReturnValue("1.0.0");
188181

189182
const customVersionInfo: EnsIndexerVersionInfo = {
190-
nodejs: "22.0.0",
191183
ponder: "1.0.0",
192184
ensDb: "2.0.0",
193185
ensIndexer: "2.0.0",

apps/ensindexer/src/lib/public-config-builder/public-config-builder.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
} from "@ensnode/ensnode-sdk";
99
import type { EnsRainbow } from "@ensnode/ensrainbow-sdk";
1010

11-
import { getEnsIndexerVersion, getNodeJsVersion, getPackageVersion } from "@/lib/version-info";
11+
import { getEnsIndexerVersion, getPackageVersion } from "@/lib/version-info";
1212

1313
export class PublicConfigBuilder {
1414
/**
@@ -80,7 +80,6 @@ export class PublicConfigBuilder {
8080
const ensDbVersion = ensIndexerVersion;
8181

8282
return validateEnsIndexerVersionInfo({
83-
nodejs: getNodeJsVersion(),
8483
ponder: getPackageVersion("ponder"),
8584
ensDb: ensDbVersion,
8685
ensIndexer: ensIndexerVersion,

apps/ensindexer/src/lib/version-info.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@ export function getEnsIndexerVersion(): string {
1111
return packageJson.version;
1212
}
1313

14-
/**
15-
* Get Node.js version
16-
*/
17-
export function getNodeJsVersion(): string {
18-
return process.versions.node;
19-
}
20-
2114
/**
2215
* Get NPM package version.
2316
*

docs/docs.ensnode.io/ensapi-openapi.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,12 @@
125125
"versionInfo": {
126126
"type": "object",
127127
"properties": {
128-
"nodejs": { "type": "string", "minLength": 1 },
129128
"ponder": { "type": "string", "minLength": 1 },
130129
"ensDb": { "type": "string", "minLength": 1 },
131130
"ensIndexer": { "type": "string", "minLength": 1 },
132131
"ensNormalize": { "type": "string", "minLength": 1 }
133132
},
134-
"required": ["nodejs", "ponder", "ensDb", "ensIndexer", "ensNormalize"]
133+
"required": ["ponder", "ensDb", "ensIndexer", "ensNormalize"]
135134
}
136135
},
137136
"required": [

docs/ensnode.io/src/content/docs/docs/usage/api.mdx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ The response includes several important configuration categories:
8585
- **Feature Flags**: Boolean settings for experimental features and optional
8686
functionality
8787
- **Plugins**: Activated plugins
88-
- **ENSIndexer Version Information**: Node.js version, Ponder framework version,
88+
- **ENSIndexer Version Information**: Ponder framework version,
8989
ENSRainbow public config, ENSDb version, ENSIndexer version, [ENS Normalize version](https://www.npmjs.com/package/@adraffy/ens-normalize)
9090

9191
### Example response
@@ -117,7 +117,6 @@ The response includes several important configuration categories:
117117
"tokenscope"
118118
],
119119
"versionInfo": {
120-
"nodejs": "22.18.0",
121120
"ponder": "0.16.1",
122121
"ensDb": "1.5.1",
123122
"ensIndexer": "1.5.1",

0 commit comments

Comments
 (0)