Updating the unit tests (now all linting works with 100% unit test coverage and working integration tests).

Author: adrianwebb

package.json

@@ -51,4 +51,4 @@
     "nunjucks": "^3.2.4",
     "zod": "^4.1.12"
   }
-}
+}

src/services/SkillRunner.ts

@@ -23,29 +23,30 @@ export class SkillRunner implements ISkillRunner {
     private driverRegistry: DriverRegistry,
     private promptEngine: PromptEngine,
     private host: IRuntimeHost,
-  ) { }
+  ) {}
 
-  async init(): Promise<void> {
-    await this.loadYamlSkills();
+  init(): Promise<void> {
+    this.loadYamlSkills();
+    return Promise.resolve();
   }
 
-  private async loadYamlSkills(): Promise<void> {
-    if (!(await this.project.fileSystem.isDirectory(this.project.paths.skills))) {
+  private loadYamlSkills(): void {
+    if (!this.project.fileSystem.isDirectory(this.project.paths.skills)) {
       return;
     }
 
-    const files = await this.project.fileSystem.listFiles(this.project.paths.skills);
+    const files = this.project.fileSystem.listFiles(this.project.paths.skills);
 
     for (const filename of files) {
       if (filename.endsWith('.skill.yml') || filename.endsWith('.skill.yaml') || filename.endsWith('.yml')) {
         const filePath = path.join(this.project.paths.skills, filename);
         try {
-          const content = await this.project.fileSystem.readFile(filePath);
+          const content = this.project.fileSystem.readFile(filePath);
           const profile = yaml.load(content);
           const parsed = SkillSchema.parse(profile);
           this.skills[parsed.name] = parsed as ISkill;
-        } catch (e: any) {
-          this.host.log('error', `Error loading skill profile ${filename}: ${e.message}`);
+        } catch (e: unknown) {
+          this.host.log('error', `Error loading skill profile ${filename}: ${(e as Error).message}`);
         }
       }
     }

tests/unit/agents/PlannerAgent.test.ts

@@ -176,6 +176,7 @@ describe('PlannerAgent', () => {
       mockDriver.execute.mockResolvedValue(mockResult);
 
       const spy = jest.spyOn(Plan, 'fromYaml').mockImplementation(() => {
+        // eslint-disable-next-line @typescript-eslint/only-throw-error
         throw 'String Error';
       });
 

tests/unit/services/SkillRunner.test.ts

@@ -187,8 +187,8 @@ describe('SkillRunner', () => {
     it('should fail if default driver missing for provider-less skill', async () => {
       // Force skill to have no provider
       const skillNoProvider = { name: 'test-skill' };
-      // @ts-ignore - reaching into private/protected or public property
-      runner.skills['test-skill'] = skillNoProvider as any;
+      // @ts-expect-error - reaching into private/protected or public property
+      (runner.skills as Record<string, unknown>)['test-skill'] = skillNoProvider;
 
       mockRegistryGetDefault.mockReturnValue(undefined);
       await expect(runner.validateAvailableSkills()).rejects.toThrow('needs a default driver but none is available.');
@@ -197,7 +197,7 @@ describe('SkillRunner', () => {
 
   it('should fail if driver not supported', async () => {
     // Manually populate skills to bypass init/fs complexity since we are outside the describe block that calls init
-    (runner as any).skills = {
+    (runner as unknown as { skills: Record<string, unknown> }).skills = {
       'test-skill': { name: 'test-skill', provider: 'mock-driver' },
     };
 
@@ -211,7 +211,7 @@ describe('SkillRunner', () => {
   });
 
   it('should handle driver errors during validation', async () => {
-    (runner as any).skills = {
+    (runner as unknown as { skills: Record<string, unknown> }).skills = {
       'test-skill': { name: 'test-skill', provider: 'mock-driver' },
     };
 

tests/unit/workflow/Workflow.test.ts

@@ -47,11 +47,27 @@ jest.unstable_mockModule('../../../src/workflow/WorkflowGraph.js', () => ({
   DefaultWorkflowConfig: {},
 }));
 
-let Workflow: any;
+// Define the shape of the Workflow class constructor
+type WorkflowConstructor = new (
+  brain: Brain,
+  project: IProject,
+  workspace: IWorkspace,
+  host: IRuntimeHost,
+) => {
+  start(state: EngineState, onStateChange?: () => Promise<void>): Promise<void>;
+  registerState(state: State): void;
+  currentState?: State;
+  // Access private property for testing if needed, though strictly not allowed
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  states: Map<string, any>;
+};
+
+let Workflow: WorkflowConstructor;
 try {
   const mod = await import('../../../src/workflow/Workflow.js');
-  Workflow = mod.Workflow;
+  Workflow = mod.Workflow as unknown as WorkflowConstructor;
 } catch (e) {
+  // eslint-disable-next-line no-console
   console.error('Error importing Workflow module:', e);
 }
 
@@ -256,7 +272,7 @@ describe('Workflow Unit Tests', () => {
     setupMockState('PLANNING', planningRun);
 
     // Mock graph to return undefined for subsequent states to finish loop if needed
-    mockGraph.getNextState.mockImplementation((state, signal) => {
+    mockGraph.getNextState.mockImplementation((state, _signal) => {
       if (state === 'ARCHITECTING') return 'PLANNING';
       return undefined;
     });