From b6097b8bb25ed3362d0b8898172dcf9e1066b5fe Mon Sep 17 00:00:00 2001 From: atlowChemi Date: Sun, 15 Feb 2026 23:12:55 +0200 Subject: [PATCH 1/2] doc: simplify addAbortListener example The example was written before v8 supported the using keyword and hence explicitly called Symbol.dispose Since now the keyword is supported, the example can be simplified --- doc/api/events.md | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/doc/api/events.md b/doc/api/events.md index 1accb787e18fcf..c274a6d7a521e7 100644 --- a/doc/api/events.md +++ b/doc/api/events.md @@ -1908,15 +1908,10 @@ Returns a disposable so that it may be unsubscribed from more easily. const { addAbortListener } = require('node:events'); function example(signal) { - let disposable; - try { - signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); - disposable = addAbortListener(signal, (e) => { - // Do something when signal is aborted. - }); - } finally { - disposable?.[Symbol.dispose](); - } + signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); + using _ = addAbortListener(signal, (e) => { + // Do something when signal is aborted. + }); } ``` @@ -1924,15 +1919,10 @@ function example(signal) { import { addAbortListener } from 'node:events'; function example(signal) { - let disposable; - try { - signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); - disposable = addAbortListener(signal, (e) => { - // Do something when signal is aborted. - }); - } finally { - disposable?.[Symbol.dispose](); - } + signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); + using _ = addAbortListener(signal, (e) => { + // Do something when signal is aborted. + }); } ``` From 2db491cd4bbb39ad587f71f1e200e89003370da3 Mon Sep 17 00:00:00 2001 From: atlowChemi Date: Mon, 16 Feb 2026 07:30:04 +0200 Subject: [PATCH 2/2] fixup! doc: simplify addAbortListener example --- doc/api/events.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/api/events.md b/doc/api/events.md index c274a6d7a521e7..08b34383d7d183 100644 --- a/doc/api/events.md +++ b/doc/api/events.md @@ -1909,6 +1909,8 @@ const { addAbortListener } = require('node:events'); function example(signal) { signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); + // addAbortListener() returns a disposable, so the `using` keyword ensures + // the abort listener is automatically removed when this scope exits. using _ = addAbortListener(signal, (e) => { // Do something when signal is aborted. }); @@ -1920,6 +1922,8 @@ import { addAbortListener } from 'node:events'; function example(signal) { signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); + // addAbortListener() returns a disposable, so the `using` keyword ensures + // the abort listener is automatically removed when this scope exits. using _ = addAbortListener(signal, (e) => { // Do something when signal is aborted. });