backend: fix ruff issues

Author: pablogsal

backend/app/admin_auth.py

@@ -52,7 +52,7 @@ async def get_admin_session(
         select(AdminSession).where(
             and_(
                 AdminSession.session_token == session_token,
-                AdminSession.is_active == True,
+                AdminSession.is_active.is_(True),
                 AdminSession.expires_at > datetime.now(UTC).replace(tzinfo=None),
             )
         )
@@ -77,7 +77,7 @@ async def cleanup_expired_sessions(db: AsyncSession) -> None:
         select(AdminSession).where(
             and_(
                 AdminSession.expires_at <= datetime.now(UTC).replace(tzinfo=None),
-                AdminSession.is_active == True,
+                AdminSession.is_active.is_(True),
             )
         )
     )

backend/app/crud.py

@@ -411,7 +411,10 @@ async def get_auth_token_by_token(
     """Get an auth token by its token value."""
     result = await db.execute(
         select(models.AuthToken).where(
-            and_(models.AuthToken.token == token, models.AuthToken.is_active == True)
+            and_(
+                models.AuthToken.token == token,
+                models.AuthToken.is_active.is_(True),
+            )
         )
     )
     return result.scalars().first()
@@ -465,7 +468,7 @@ async def get_admin_users(db: AsyncSession) -> List[models.AdminUser]:
     """Get all admin users."""
     result = await db.execute(
         select(models.AdminUser)
-        .where(models.AdminUser.is_active == True)
+        .where(models.AdminUser.is_active.is_(True))
         .order_by(models.AdminUser.added_at)
     )
     return result.scalars().all()
@@ -479,7 +482,7 @@ async def get_admin_user_by_username(
         select(models.AdminUser).where(
             and_(
                 models.AdminUser.github_username == username,
-                models.AdminUser.is_active == True,
+                models.AdminUser.is_active.is_(True),
             )
         )
     )

backend/app/database.py

@@ -1,3 +1,6 @@
+from contextlib import asynccontextmanager
+from typing import AsyncGenerator
+
 import logging
 from sqlalchemy.ext.asyncio import create_async_engine, AsyncSession, async_sessionmaker
 from sqlalchemy.orm import sessionmaker
@@ -85,11 +88,6 @@ async def drop_tables():
     async with engine.begin() as conn:
         await conn.run_sync(Base.metadata.drop_all)
 
-
-from contextlib import asynccontextmanager
-from typing import AsyncGenerator
-
-
 @asynccontextmanager
 async def transaction_scope() -> AsyncGenerator[AsyncSession, None]:
     """

backend/scripts/manage_tokens.py

@@ -142,9 +142,9 @@ async def list_tokens() -> None:
 async def deactivate_token(token_id: int) -> None:
     """Deactivate an authentication token."""
     # Ensure database tables exist
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             success = await crud.deactivate_auth_token(db, token_id)
             if success:
@@ -160,9 +160,9 @@ async def deactivate_token(token_id: int) -> None:
 
 async def reactivate_token(token_id: int) -> None:
     """Reactivate a deactivated authentication token."""
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             result = await db.execute(
                 select(models.AuthToken).where(models.AuthToken.id == token_id)
@@ -190,9 +190,9 @@ async def update_token_info(
     token_id: int, name: str = None, description: str = None
 ) -> None:
     """Update token name and/or description."""
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             result = await db.execute(
                 select(models.AuthToken).where(models.AuthToken.id == token_id)
@@ -233,9 +233,9 @@ async def search_tokens(
     inactive_only: bool = False,
 ) -> None:
     """Search tokens by name or description patterns."""
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             query = select(models.AuthToken)
 
@@ -251,9 +251,9 @@ async def search_tokens(
                 )
 
             if active_only:
-                conditions.append(models.AuthToken.is_active == True)
+                conditions.append(models.AuthToken.is_active.is_(True))
             elif inactive_only:
-                conditions.append(models.AuthToken.is_active == False)
+                conditions.append(models.AuthToken.is_active.is_(False))
 
             if conditions:
                 query = query.where(and_(*conditions))
@@ -308,9 +308,9 @@ async def search_tokens(
 
 async def show_token_details(token_id: int) -> None:
     """Show detailed information about a specific token."""
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             result = await db.execute(
                 select(models.AuthToken).where(models.AuthToken.id == token_id)
@@ -349,17 +349,17 @@ async def show_token_details(token_id: int) -> None:
 
 async def show_token_analytics() -> None:
     """Show analytics and statistics about token usage."""
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             # Get basic counts
             total_result = await db.execute(select(func.count(models.AuthToken.id)))
             total_tokens = total_result.scalar()
 
             active_result = await db.execute(
                 select(func.count(models.AuthToken.id)).where(
-                    models.AuthToken.is_active == True
+                    models.AuthToken.is_active.is_(True)
                 )
             )
             active_tokens = active_result.scalar()
@@ -456,11 +456,11 @@ async def show_token_analytics() -> None:
 
 async def cleanup_old_tokens(days: int = 90, dry_run: bool = True) -> None:
     """Clean up unused tokens older than specified days."""
-    await create_tables()
+    await db_manager.create_tables()
 
     cutoff_date = datetime.utcnow() - timedelta(days=days)
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             # Find tokens that are either never used and old, or inactive and old
             result = await db.execute(
@@ -476,7 +476,7 @@ async def cleanup_old_tokens(days: int = 90, dry_run: bool = True) -> None:
             result2 = await db.execute(
                 select(models.AuthToken).where(
                     and_(
-                        models.AuthToken.is_active == False,
+                        models.AuthToken.is_active.is_(False),
                         models.AuthToken.created_at < cutoff_date,
                     )
                 )
@@ -547,13 +547,13 @@ async def export_tokens(
     format_type: str = "json", include_inactive: bool = True
 ) -> None:
     """Export token information (excluding actual token values)."""
-    await create_tables()
+    await db_manager.create_tables()
 
-    async with AsyncSessionLocal() as db:
+    async with db_manager.AsyncSession() as db:
         try:
             query = select(models.AuthToken)
             if not include_inactive:
-                query = query.where(models.AuthToken.is_active == True)
+                query = query.where(models.AuthToken.is_active.is_(True))
 
             query = query.order_by(models.AuthToken.created_at)
             result = await db.execute(query)
@@ -672,9 +672,7 @@ def main():
     )
 
     # List tokens command
-    list_parser = subparsers.add_parser(
-        "list", help="List all existing authentication tokens"
-    )
+    subparsers.add_parser("list", help="List all existing authentication tokens")
 
     # Show token details command
     details_parser = subparsers.add_parser(
@@ -724,7 +722,7 @@ def main():
     )
 
     # Analytics command
-    analytics_parser = subparsers.add_parser(
+    subparsers.add_parser(
         "analytics", help="Show token usage analytics and statistics"
     )
 

backend/scripts/populate_binaries.py

@@ -183,7 +183,7 @@ async def populate_binaries(force: bool = False, database_url: str = None):
                         display_order=binary_data.get("display_order", 0),
                     )
 
-                    new_binary = await crud.create_binary(db, binary_create)
+                    await crud.create_binary(db, binary_create)
                     print(f"✅ Created binary '{binary_id}': {binary_data['name']}")
                     print(f"   Flags: {binary_data['flags']}")
                     print(f"   Description: {binary_data['description']}")