You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Simplify worker argument handling and remove parallel processing
- Change benchmark command to take commit_range as positional argument
- Make repo-path optional with --repo-path flag, defaults to temporary clone
- Remove parallel processing options (--max-workers, --batch-size, --local-checkout)
- Simplify command processing by removing unused parallel execution paths
- Clean up imports and remove multiprocessing dependencies
- Add trailing newline to runs.py and minor formatting cleanup
Copy file name to clipboardExpand all lines: worker/src/memory_tracker_worker/args.py
+5-23Lines changed: 5 additions & 23 deletions
Original file line number
Diff line number
Diff line change
@@ -60,14 +60,13 @@ def parse_args():
60
60
help='Run memory benchmarks on CPython commits'
61
61
)
62
62
benchmark_parser.add_argument(
63
-
'repo_path',
64
-
nargs='?',
65
-
type=Path,
66
-
help='Path to CPython repository (optional, will clone if not provided)'
63
+
'commit_range',
64
+
help='Git commit range to benchmark (e.g., HEAD~5..HEAD, HEAD^, commit_sha)'
67
65
)
68
66
benchmark_parser.add_argument(
69
-
'commit_range',
70
-
help='Git commit range to benchmark (e.g., HEAD~5..HEAD)'
67
+
'--repo-path', '-r',
68
+
type=Path,
69
+
help='Path to CPython repository. If not provided, will clone CPython to a temporary directory.'
71
70
)
72
71
benchmark_parser.add_argument(
73
72
'--output-dir', '-o',
@@ -106,18 +105,6 @@ def parse_args():
106
105
action='store_true',
107
106
help='Force overwrite existing output directories for commits'
108
107
)
109
-
benchmark_parser.add_argument(
110
-
'--max-workers', '-j',
111
-
type=int,
112
-
default=1,
113
-
help='Maximum number of parallel workers. Creates temporary repo copies for each worker to avoid conflicts. (default: 1 for sequential processing)'
114
-
)
115
-
benchmark_parser.add_argument(
116
-
'--batch-size', '-b',
117
-
type=int,
118
-
default=None,
119
-
help='Number of commits to process in each parallel batch. Useful for memory management with large commit ranges. (default: same as max-workers)'
120
-
)
121
108
benchmark_parser.add_argument(
122
109
'--auth-token',
123
110
help='Authentication token for uploading results to server. Can also be set via MEMORY_TRACKER_TOKEN environment variable.'
@@ -127,11 +114,6 @@ def parse_args():
127
114
default='http://localhost:8000',
128
115
help='Base URL for the memory tracker API (default: http://localhost:8000)'
129
116
)
130
-
benchmark_parser.add_argument(
131
-
'--local-checkout',
132
-
action='store_true',
133
-
help='Use local checkout for building. Runs git clean -fxd, configures once, and runs make for each commit. Incompatible with parallel processing (-j > 1).'
0 commit comments