fix: list transactions

Author: rameezk

docs/usage/transactions.md

@@ -36,20 +36,22 @@ transaction = client.transactions.create(
 
 ```python
 # Basic listing
-transactions = client.transactions.list(account_id="acc_123")
+transactions = client.transactions.list()
 
 # With date filters
 transactions = client.transactions.list(
-    account_id="acc_123",
     start_date=date(2024, 1, 1),
     end_date=date(2024, 1, 31),
     type="expense",
 )
 
 for txn in transactions:
-    print(f"{txn.transaction_date}: {txn.description} ({txn.amount})")
+    print(f"{txn.transaction_date}: {txn.description} ({txn.amount.format()})")
 ```
 
+!!! note "Filtering"
+    The API supports filtering by `category_id`, `start_date`, `end_date`, and `type`. Filtering by account ID is not supported.
+
 ## Archive a Transaction
 
 ```python

src/finwise/models/transaction.py

@@ -2,12 +2,15 @@
 
 from __future__ import annotations
 
+import datetime as dt
 from datetime import date, datetime
 from decimal import Decimal
 from typing import Literal, Optional
 
 from pydantic import BaseModel, ConfigDict, Field
 
+from finwise.models.account_balance import Amount
+
 
 class TransactionCreateRequest(BaseModel):
     """
@@ -50,37 +53,54 @@ class Transaction(BaseModel):
 
     Attributes:
         id: Unique transaction identifier.
-        account_id: ID of the account.
-        amount: Transaction amount.
-        transaction_date: Date of the transaction.
+        user_id: ID of the user who owns this transaction.
+        account_id: ID of the account (nullable).
+        amount: Transaction amount with currency.
+        date: Date/time of the transaction.
         description: Transaction description (if set).
         category_id: Category ID (if categorized).
-        category_name: Category name (if categorized).
         type: Transaction type.
         created_at: When the transaction was created.
         updated_at: When the transaction was last updated.
         archived_at: When the transaction was archived (None if active).
+        data_import_id: ID of the data import that created this record.
 
     Example:
         >>> transactions = client.transactions.list()
         >>> for txn in transactions:
-        ...     print(f"{txn.transaction_date}: {txn.description} ({txn.amount})")
+        ...     print(f"{txn.date}: {txn.description} ({txn.amount.format()})")
     """
 
     id: str
-    account_id: str = Field(..., alias="accountId")
-    amount: Decimal
-    transaction_date: date = Field(..., alias="transactionDate")
+    user_id: str = Field(..., alias="userId")
+    account_id: Optional[str] = Field(None, alias="accountId")
+    amount: Amount
+    date: datetime
     description: Optional[str] = None
     category_id: Optional[str] = Field(None, alias="categoryId")
-    category_name: Optional[str] = Field(None, alias="categoryName")
     type: str
     created_at: datetime = Field(..., alias="createdAt")
     updated_at: datetime = Field(..., alias="updatedAt")
     archived_at: Optional[datetime] = Field(None, alias="archivedAt")
+    data_import_id: Optional[str] = Field(None, alias="dataImportId")
 
     model_config = ConfigDict(populate_by_name=True)
 
+    @property
+    def value(self) -> Decimal:
+        """Get the transaction amount value."""
+        return self.amount.amount
+
+    @property
+    def currency(self) -> str:
+        """Get the currency code."""
+        return self.amount.currency_code
+
+    @property
+    def transaction_date(self) -> dt.date:
+        """Get the transaction date (for backwards compatibility)."""
+        return self.date.date()
+
     @property
     def is_archived(self) -> bool:
         """Check if the transaction is archived."""

src/finwise/resources/transactions.py

@@ -110,7 +110,6 @@ def create(
     def list(
         self,
         *,
-        account_id: Optional[str] = None,
         category_id: Optional[str] = None,
         start_date: Optional[date] = None,
         end_date: Optional[date] = None,
@@ -119,11 +118,10 @@ def list(
         """
         List transactions with optional filtering.
 
-        Note: The API does not support pagination for this endpoint.
+        Note: The API does not support pagination or filtering by account ID.
         All matching transactions are returned.
 
         Args:
-            account_id: Optional filter by account ID.
             category_id: Optional filter by category ID.
             start_date: Optional filter for transactions on or after this date.
             end_date: Optional filter for transactions on or before this date.
@@ -136,24 +134,19 @@ def list(
             >>> # List all transactions
             >>> transactions = client.transactions.list()
             >>> for txn in transactions:
-            ...     print(f"{txn.description}: {txn.amount}")
+            ...     print(f"{txn.description}: {txn.amount.format()}")
             >>>
             >>> # Filter by date range
             >>> transactions = client.transactions.list(
             ...     start_date=date(2024, 1, 1),
             ...     end_date=date(2024, 1, 31),
             ... )
             >>>
-            >>> # Filter by account and type
-            >>> expenses = client.transactions.list(
-            ...     account_id="acc_123",
-            ...     type="expense",
-            ... )
+            >>> # Filter by type
+            >>> expenses = client.transactions.list(type="expense")
         """
         params: dict[str, str] = {}
 
-        if account_id:
-            params["accountId"] = account_id
         if category_id:
             params["categoryId"] = category_id
         if start_date:

tests/conftest.py

@@ -99,16 +99,20 @@ def sample_transaction() -> dict[str, Any]:
     """Sample transaction response data."""
     return {
         "id": "txn_789xyz",
+        "userId": "user_123",
         "accountId": "acc_123abc",
-        "amount": "-50.00",
-        "transactionDate": "2024-01-15",
+        "amount": {
+            "amount": "-50.00",
+            "currencyCode": "USD",
+        },
+        "date": "2024-01-15T10:00:00Z",
         "description": "Grocery shopping",
         "categoryId": "cat_groceries",
-        "categoryName": "Groceries",
         "type": "expense",
         "createdAt": "2024-01-15T10:00:00Z",
         "updatedAt": "2024-01-15T10:00:00Z",
         "archivedAt": None,
+        "dataImportId": None,
     }