Open
Conversation
Contributor
|
Can we include documentation of the intended handling of diamond inheritance and tests of the same? |
andrewmwells-amazon
requested changes
Feb 20, 2026
Contributor
andrewmwells-amazon
left a comment
andrewmwells-amazon
left a comment
There was a problem hiding this comment.
I don't see intended semantics of diamond inheritance documented nor code forbidding it. In either case, I think we should include some tests for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Map.constfunction to the Core factory<value> as <Type>and<value> is <Type>, andextendsfor composite types.Testing
sameFieldNameDifferentTypeto the mutable fields test file