Skip to content

Commit 3bba8d3

Browse files
butler54claude
andcommitted
fix: resolve CI lint failures for PR #69
Address ansible-lint (risky-shell-pipe, no-changed-when, line-length), super-linter markdown and natural language errors, and JSON schema validation by resetting clusterGroupName to simple. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3b4014d commit 3bba8d3

5 files changed

Lines changed: 16 additions & 13 deletions

File tree

AGENTS.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This file provides rules and context for any AI coding assistant working in this
55

66
## Critical Rules
77

8-
- **DO NOT** edit anything under `/common/`. It is a read-only git subtree from the upstream validated patterns framework.
8+
- **DO NOT** edit anything under `/common/`. It is a read-only Git subtree from the upstream validated patterns framework.
99
- **DO NOT** commit secrets, credentials, or private keys. `values-secret.yaml.template` is a template only.
1010
- **DO NOT** use Kustomize. This project uses Helm exclusively.
1111
- **DO NOT** create charts with `apiVersion: v1`. Use `apiVersion: v2` (Helm 3+).
@@ -23,7 +23,7 @@ Use the **first** approach that fits your requirement:
2323

2424
## Project Structure
2525

26-
```
26+
```text
2727
├── ansible/ # Ansible playbooks (imperative jobs)
2828
├── charts/
2929
│ ├── all/
@@ -54,9 +54,9 @@ Use the **first** approach that fits your requirement:
5454

5555
## Companion Chart Repositories
5656

57-
Several charts in this repo have companion repositories for independent versioning and reuse. Develop and test in this repo first (charts deploy via `path:`), then sync changes to the companion repo.
57+
Several charts in this repository have companion repositories for independent versioning and reuse. Develop and test in this repository first (charts deploy via `path:`), then sync changes to the companion repository.
5858

59-
| Local Path | Companion Repo | Purpose |
59+
| Local Path | Companion Repository | Purpose |
6060
|---|---|---|
6161
| `charts/hub/trustee/` | `trustee-chart` | Trustee / KBS on hub |
6262
| `charts/hub/sandbox-policies/` | `sandboxed-policies-chart` | ACM policies hub → spoke |
@@ -132,7 +132,7 @@ All commands run via `./pattern.sh make <target>`:
132132
| `load-secrets` | Load secrets into the configured backend |
133133
| `uninstall` | Uninstall the pattern |
134134

135-
See the README for secrets backend configuration, RHDP environment variables, and additional maintenance commands.
135+
See the readme for secrets backend configuration, RHDP environment variables, and additional maintenance commands.
136136

137137
## Validation and CI
138138

README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ All previous versions used pre-GA (Technology Preview) releases of Trustee:
4747
- Azure DNS hosting the cluster's DNS zone
4848
- Tools on your workstation: `podman`, `yq`, `jq`, `skopeo`
4949
- OpenShift pull secret saved at `~/pull-secret.json` (download from [console.redhat.com](https://console.redhat.com/openshift/downloads))
50-
- Fork the repo — ArgoCD reconciles cluster state against your fork, so changes must be pushed to your remote
51-
50+
- Fork the repository — ArgoCD reconciles cluster state against your fork, so changes must be pushed to your remote
5251

5352
### Secrets and PCR setup
5453

@@ -130,5 +129,3 @@ Deployment commands:
130129
- Multi-cluster: `bash rhdp/wrapper-multicluster.sh <azure-region>`
131130

132131
The wrapper scripts handle cluster provisioning via `openshift-install`, secret generation, PCR retrieval, and pattern installation.
133-
134-

ansible/init-data-gzipper.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747

4848
- name: Gzip and base64 encode the rendered content
4949
ansible.builtin.shell: |
50+
set -o pipefail
5051
cat "{{ rendered_path }}" | gzip | base64 -w0
5152
register: initdata_encoded
5253
changed_when: false
@@ -55,16 +56,21 @@
5556
# The script performs the following steps:
5657
# 1. hash=$(sha256sum initdata.toml | cut -d' ' -f1): Computes the sha256 hash of 'initdata.toml' and assigns it to $hash.
5758
# 2. initial_pcr=0000000000000000000000000000000000000000000000000000000000000000: Initializes a string of zeros as the initial PCR value.
58-
# 3. PCR8_HASH=$(echo -n "$initial_pcr$hash" | xxd -r -p | sha256sum | cut -d' ' -f1): Concatenates initial_pcr and $hash, converts from hex to binary, computes its sha256 hash, and stores the result as PCR8_HASH.
59+
# 3. PCR8_HASH=$(echo -n "$initial_pcr$hash" | xxd -r -p | sha256sum | cut -d' ' -f1):
60+
# Concatenates initial_pcr and $hash, converts from hex to binary,
61+
# computes its sha256 hash, and stores the result as PCR8_HASH.
5962
# 4. echo $PCR8_HASH: Outputs the PCR hash value.
60-
# The important part: The 'register: pcr8_hash' registers the **stdout of the command**, which is the value output by 'echo $PCR8_HASH', as 'pcr8_hash.stdout' in Ansible.
63+
# The important part: The 'register: pcr8_hash' registers the **stdout of the command**,
64+
# which is the value output by 'echo $PCR8_HASH', as 'pcr8_hash.stdout' in Ansible.
6165
# It does NOT register an environment variable, but rather the value actually printed by 'echo'.
6266
- name: Register init data pcr into a var
6367
ansible.builtin.shell: |
68+
set -o pipefail
6469
hash=$(sha256sum "{{ rendered_path }}" | cut -d' ' -f1)
6570
initial_pcr=0000000000000000000000000000000000000000000000000000000000000000
6671
PCR8_HASH=$(echo -n "$initial_pcr$hash" | xxd -r -p | sha256sum | cut -d' ' -f1) && echo $PCR8_HASH
6772
register: pcr8_hash
73+
changed_when: false
6874

6975

7076
- name: Create/update ConfigMap with gzipped+base64 content

docs/dell-tdx-configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Navigate to: **System BIOS → Processor Settings → Software Guard Extensions
8888

8989
## Configuration Summary (Order of Operations)
9090

91-
```
91+
```text
9292
1. Disable Node Interleaving → Save & Reboot
9393
2. Enable x2APIC Mode → Save & Reboot
9494
3. Disable CPU Physical Address Limit → Save & Reboot

values-global.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ main:
2424
# WARNING
2525
# This default configuration uses a single cluster on azure.
2626
# It fundamentally violates the separation of duties.
27-
clusterGroupName: trusted-hub
27+
clusterGroupName: simple
2828
multiSourceConfig:
2929
enabled: true
3030
clusterGroupChartVersion: 0.9.*

0 commit comments

Comments
 (0)