fix(gemini): infer string type for enum schemas in anyOf/oneOf#1547
Merged
joshua-mo-143 merged 1 commit into0xPlaygrounds:mainfrom Mar 29, 2026
Merged
Conversation
Contributor
|
thank you! lgtm |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1540
Description
Schema conversion for
Option<enum>fields (anyOf/oneOf containing objects with anenumkey) was producing an empty type string, causing a 400 Bad Request from the Gemini API.The root cause is in
extract_type_from_composition: when iterating over anyOf/oneOf schemas, it checks for an explicittypefield andproperties, but not for theenumkey. Enum schemas without an explicit type were falling through toNoneand ultimately returning an empty string.The fix adds an
else if obj.contains_key("enum")branch that returns"string".Changes
rig-core/src/providers/gemini/completion.rs: Addedenumkey check inextract_type_from_compositionto return"string"Testing
cargo test -p rig-core --libpasses (439 tests).