Conversation
felipeelia
left a comment
There was a problem hiding this comment.
@ZacharyRener any chance we can add some e2e tests for this one? Enabling Did you mean should make an option in Instant Results editable, for example.
|
@felipeelia The staleness issue happens when the So I setup a test plugin here to simulate the conflict and added an e2e test I'll move this to review once the tests are all passing but just fyi. |
…0up/ElasticPress into fix/stale-interface-feature-dependency
|
The purpose with this PR now is to refresh the feature settings and settings schema on save, instead of requiring a refresh, universally. The test here was updated to be a more generic replication of the issue instead of the temporarily_disabled check from earlier. For SemanticSearch in particular, EP Labs needs an update to actually consider whether the feature is active before adding the algorithms: 10up/ElasticPressLabs#184 |
re Setting Refresh
…0up/ElasticPress into fix/stale-interface-feature-dependency
|
@felipeelia I have a good solution in place now. Just a matter of getting tests passing now |
Description of the Change
The purpose with this PR is to refresh the feature settings and settings schema on save, instead of requiring a refresh, universally. No changes to EP labs or any feature needed
Closes #4267
How to test the Change
Changelog Entry
Credits
Props @ZacharyRener
Checklist: