Support field lookup by field.id as fallback to field.label#131
Open
AlonNaor22 wants to merge 1 commit into1Password:mainfrom
Open
Support field lookup by field.id as fallback to field.label#131AlonNaor22 wants to merge 1 commit into1Password:mainfrom
AlonNaor22 wants to merge 1 commit into1Password:mainfrom
Conversation
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Extend load_dict and load to resolve fields by field.id when a field.label match is not found. The lookup order is: label first, then id, then raise an error. Section lookup is also extended to support both section.label and section.id. Closes 1Password#50 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d21e4ae to
b1e1765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_dictandloadto resolve fields byfield.idwhen afield.labelmatch is not foundsection.labelandsection.idFiles changed
src/onepasswordconnectsdk/config.py— extracted reusable_find_field()and_match_field()helpers, addedFIELD_MATCH_ATTRIBUTESconstant for configurable lookup order, extended_convert_sections_to_dict()to support section id keyssrc/tests/test_config.py— 3 new tests: field id lookup viaload_dict, field id lookup viaload, and label-takes-priority verificationTest plan
test_loadandtest_load_dictstill pass (no regressions)test_load_dict_by_field_id— verifies field.id fallback withload_dicttest_load_by_field_id— verifies field.id fallback withloadtest_load_dict_label_takes_priority— verifies label match wins over id matchCloses #50
🤖 Generated with Claude Code