Skip to content

Make on-demand download timeout configurable.#668

Draft
SternI wants to merge 3 commits into4sval:devfrom
SternI:dev
Draft

Make on-demand download timeout configurable.#668
SternI wants to merge 3 commits into4sval:devfrom
SternI:dev

Conversation

@SternI
Copy link
Copy Markdown
Contributor

@SternI SternI commented Apr 2, 2026

The 30 seconds timeout was insufficient for large on-demand downloads.
Timeout is now configurable via settings.

@4sval
Copy link
Copy Markdown
Owner

4sval commented Apr 2, 2026

too targeted/too niche, I would rather see a try catch on c4p than another settings nobody will use

@h4lfheart
Copy link
Copy Markdown
Collaborator

too targeted/too niche, I would rather see a try catch on c4p than another settings nobody will use

I had to add a setting for this in Fortnite Porting for all api requests and in on-demand settings. You would be surprised by how many people with horrible wifi need it for small requests to go through, it wouldn't hurt to add.

@4sval
Copy link
Copy Markdown
Owner

4sval commented Apr 2, 2026

I had to add a setting for this in Fortnite Porting for all api requests and in on-demand settings. You would be surprised by how many people with horrible wifi need it for small requests to go through, it wouldn't hurt to add.

well, of course, it’s for high res textures on fortnite, your users are the exact target of this PR 😄

if it would not hurt to add then @SternI rename it HTTP Request Timeout or something like this and use it for everything.

  • default to 30
  • it does not have to be a directory setting
  • do not use Math.Max or use it once in a setter
  • you don’t need a backing field in the settings viewmodel, just a simple integer control two way binded straight to the settings field
  • you removed some stuff from the previous PR

@SternI
Copy link
Copy Markdown
Contributor Author

SternI commented Apr 3, 2026

I had to add a setting for this in Fortnite Porting for all api requests and in on-demand settings. You would be surprised by how many people with horrible wifi need it for small requests to go through, it wouldn't hurt to add.

well, of course, it’s for high res textures on fortnite, your users are the exact target of this PR 😄

if it would not hurt to add then @SternI rename it HTTP Request Timeout or something like this and use it for everything.

  • default to 30
  • it does not have to be a directory setting
  • do not use Math.Max or use it once in a setter
  • you don’t need a backing field in the settings viewmodel, just a simple integer control two way binded straight to the settings field
  • you removed some stuff from the previous PR

Done

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need this

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the correct input control

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need this

@SternI
Copy link
Copy Markdown
Contributor Author

SternI commented Apr 3, 2026

What about this

@4sval 4sval marked this pull request as draft April 4, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants