Merged
Conversation
jwrosewell
requested changes
Mar 4, 2026
Contributor
jwrosewell
left a comment
jwrosewell
left a comment
There was a problem hiding this comment.
I have discussed with @Rakesh51D @Eddie51D 5th March. I've been through the comments with them in the office today.
|
|
||
| Properties of this type have values between 0-10, where 0 indicates unknown, 1 is a low diversity, and 10 is high diversity. | ||
|
|
||
| If, for an IP range, there is an average of 1 device per IP, then the diversity score would be 1. However, if there were 10 or more devices per IP, the score would be 10. This is a slight simplification, but is generally accurate. Details of the full calculation are in the [calculation](#calculation) section. |
Contributor
There was a problem hiding this comment.
I'm not sure the upper limit of 10 should be used as it makes it harder for people to understand the calculation later. They will leave the paragraph at this point wondering what happens if 20 different Platforms, Hardware Models, Apps were seen? We should probably not use "Device" in the explanation. That is an internal term for the project before we made it clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.