Conversation
…update mappings for zfull height coordinate
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (25.0%) is below the target coverage (90.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=======================================
+ Coverage 47.5% 54.0% +6.6%
=======================================
Files 22 20 -2
Lines 4183 3875 -308
Branches 0 714 +714
=======================================
+ Hits 1986 2094 +108
+ Misses 2197 1604 -593
- Partials 0 177 +177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhaegar325
left a comment
There was a problem hiding this comment.
While testing the PR, an issue has occured:
File [/g/data/tm70/yz9299/ARE/ACCESS-MOPPy/src/access_moppy/atmosphere.py:139](https://are.nci.org.au/g/data/tm70/yz9299/ARE/ACCESS-MOPPy/src/access_moppy/atmosphere.py#line=138), in Atmosphere_CMORiser.select_and_process_variables(self)
137 # Ensure the CMOR variable exists
138 if self.cmor_name not in self.ds:
--> 139 raise ValueError(
140 f"Internal calculation function '{func_name}' did not generate variable '{self.cmor_name}'"
141 )
143 return
145 # Original logic for other calculation types
146 # Select input variables required for the CMOR variable
ValueError: Internal calculation function 'load_zfull_resource' did not generate variable 'zfull'
This is because the dataset we loaded is a raw data with following format:
ds <xarray.Dataset> Size: 4MB
Dimensions: (lev: 38, lat: 145, lon: 192, bnds: 2)
Coordinates:
* lev (lev) float64 304B 20.0 80.0 ... 3.925e+04
sigma_theta (lev) float64 304B ...
* lat (lat) float64 1kB -90.0 -88.75 -87.5 ... 88.75 90.0
* lon (lon) float64 2kB 0.0 1.875 3.75 ... 356.2 358.1
Dimensions without coordinates: bnds
Data variables:
fld_s15i101 (lev, lat, lon) float32 4MB ...
latitude_longitude int32 4B ...
lat_bnds (lat, bnds) float64 2kB ...
lon_bnds (lon, bnds) float64 3kB ...
theta_level_height_bnds (lev, bnds) float64 608B ...
sigma_theta_bnds (lev, bnds) float64 608B ...
Attributes:
history: File /scratch/tm70/sw6175/access-esm/archive/get-model-heig...
Conventions: CF-1.6
source: Data from Met Office Unified Model
um_version: 7.3
which hasn't been cmorised yet and still have the stash code as it variable name.
Not sure if I make it right, I use following parameters when generate cmoriser:
cmoriser = ACCESS_ESM_CMORiser(
input_data=None,
compound_name="fx.zfull",
experiment_id="piControl",
source_id="ACCESS-ESM1-5",
variant_label="r1i1p1f1",
grid_label="gn",
activity_id="CMIP",
output_path=OUTPUT_FOLDER,
parent_info=parent_experiment_config,
)
rbeucher
left a comment
There was a problem hiding this comment.
I have corrected the bug but the output is not correct. Still need to revise...
Add support for fx.zull using one off generated file.
will Fix #212