Skip to content

fix: Add index validation for batch_index in NECropKernel #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArmDude wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix: Add index validation for batch_index in NECropKernel #1258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/core/NEON/kernels/NECropKernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2022 Arm Limited.
* Copyright (c) 2019-2022, 2026 Arm Limited.
*
* SPDX-License-Identifier: MIT
*
Expand Down Expand Up @@ -323,7 +323,10 @@ void NECropKernel::run(const Window &window, const ThreadInfo &info)

const auto *uk = get_implementation(CropSelectorData{_input->info()->data_type()});

uint32_t batch_index = *(reinterpret_cast<int32_t *>(_box_ind->ptr_to_element(Coordinates(_crop_box_ind))));
uint32_t batch_index = *(reinterpret_cast<int32_t *>(_box_ind->ptr_to_element(Coordinates(_crop_box_ind))));
ARM_COMPUTE_ERROR_ON(batch_index >=
_input->info()->tensor_shape()[3]); // Check if batch_index is outside the number of batches

Coordinates input_offset(
0, _end[0] < _start[0] ? _start[0] - _cols_out_of_bounds[0] : _start[0] + _cols_out_of_bounds[0],
_end[1] < _start[1] ? _start[1] - _rows_out_of_bounds[0] : _start[1] + _rows_out_of_bounds[0], batch_index);
Expand Down