Skip to content

Add sqlite 3 missing sink#591

Merged
bitterpanda63 merged 11 commits intomainfrom
add-sqlite-3-missing-sink
Mar 2, 2026
Merged

Add sqlite 3 missing sink#591
bitterpanda63 merged 11 commits intomainfrom
add-sqlite-3-missing-sink

Conversation

@bitterpanda63
Copy link
Member

@bitterpanda63 bitterpanda63 commented Feb 12, 2026

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 1 Resolved Issues: 0

🚀 New Features

  • Added sqlite3 sink, tests, and integration into package imports.
  • Introduced modify_arguments helper to inject and adjust call arguments.

⚡ Enhancements

  • Added patch_immutable_class to enable wrapping methods on C-backed classes.

More info

@bitterpanda63 bitterpanda63 marked this pull request as ready for review March 2, 2026 17:51
"cursor": _cursor_patch
}

if _PATCH_CONNECTION_EXECUTE:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_connect references _PATCH_CONNECTION_EXECUTE, but it isn't defined/imported here, so calling sqlite3.connect will raise NameError during patching.

Details

✨ AI Reasoning
​The code builds a set of patches for the connection factory. While doing so, it branches on a flag to decide whether to also patch connection-level execute methods. However, the flag being checked is not defined anywhere in the shown code. That means calling the connect wrapper will raise an exception at that point, preventing any patching from working.

🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

@bitterpanda63 bitterpanda63 merged commit bf3acdb into main Mar 2, 2026
84 checks passed
@bitterpanda63 bitterpanda63 deleted the add-sqlite-3-missing-sink branch March 2, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants