Conversation
AlexW00
added a commit
that referenced
this pull request
Apr 15, 2026
Bookmarks were created and resolved with `options: []` instead of `.withSecurityScope`, so the sandbox access grant was not embedded in the bookmark data. macOS sometimes caches grants across restarts, masking the bug — but OS updates and app re-signs clear the cache, leaving `contentsOfDirectory` to fail silently and the sidebar empty. Changes: - Use `.withSecurityScope` when creating and resolving bookmarks - Check and log `startAccessingSecurityScopedResource()` return value - Replace silent `try?` in `contentsOfDirectory` with explicit error logging Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AlexW00
added a commit
that referenced
this pull request
Apr 27, 2026
…it (#40) * Fix macOS sidebar empty after restart or app update (#38) Bookmarks were created and resolved with `options: []` instead of `.withSecurityScope`, so the sandbox access grant was not embedded in the bookmark data. macOS sometimes caches grants across restarts, masking the bug — but OS updates and app re-signs clear the cache, leaving `contentsOfDirectory` to fail silently and the sidebar empty. Changes: - Use `.withSecurityScope` when creating and resolving bookmarks - Check and log `startAccessingSecurityScopedResource()` return value - Replace silent `try?` in `contentsOfDirectory` with explicit error logging Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add macOS update note for the bookmark fix Shows a changelog note on first launch after updating to v1.3, mirroring the iOS changelog pattern. The note explains the sidebar bug fix and instructs users to re-select their storage folder once. - MacChangelogData: static changelog entries (same pattern as iOS) - MacChangelogManager: tracks last-seen version via UserDefaults - AppDelegate: checks for pending changelog before restoring notes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix activationPolicy call missing parentheses `NSApplication.shared.activationPolicy` is a method, not a property — needs `()` to call it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix app quitting when closing the Settings window applicationShouldTerminateAfterLastWindowClosed returned true whenever the Dock icon was hidden, but macOS counts the Settings window too. Closing Settings as the last window would quit the app unexpectedly. Now only returns true when no note windows remain (checked via ZettelWindowManager.hasNoWindows). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix Dock icon click creating new windows instead of focusing Two issues: 1. applicationShouldHandleReopen returned true, causing macOS to also perform its default reopen behavior on top of ours — leading to duplicate windows and broken Stage Manager integration. 2. The hasVisibleWindows flag is unreliable for NSPanel windows with accessory activation policy, so it always took the create-window branch. Now uses our own window tracking (hasNoWindows) and returns false to prevent macOS default behavior. Added focusLastWindow() to bring just the last-used window forward on Dock click. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.