[PWGEM] Fix Event subscription in process functions#15218
Merged
mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom Mar 2, 2026
Merged
[PWGEM] Fix Event subscription in process functions#15218mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom
mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom
Conversation
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#15218
Steffimro
requested review from
alibuild,
dsekihat,
jokonig,
m-c-danisch,
mhemmer-cern,
mikesas,
novitzky and
rbailhac
as code owners
mhemmer-cern
approved these changes
Mar 2, 2026
Collaborator
mhemmer-cern
left a comment
mhemmer-cern
left a comment
There was a problem hiding this comment.
This should fix some oversights that came with #15108 which resulted in workflow crashes.
vkucera
reviewed
Mar 2, 2026
| // Note that reconstructed collisions without mc collisions are already rejected in CreateEMEventPhoton in MC. | ||
|
|
||
| void processPCM(aod::EMEvents const& collisions, aod::V0PhotonsKF const& photons) | ||
| void processPCM(aod::EMEvents_004 const& collisions, aod::V0PhotonsKF const& photons) |
Collaborator
There was a problem hiding this comment.
Why do you need an explicit table version in a subscription?
Collaborator
There was a problem hiding this comment.
Because in the EM code we were using the same event tables before. Then it was recently changed in a way that the photon/meson code would still use the version 004 while the dileptons went to version 005. Since the dilepton group did not want to cause changes in the photon code, they tried to kept it at 004 for us, but these few subscriptions got overlooked. See the linked PR from my approval comment.
Collaborator
There was a problem hiding this comment.
This will be a mess to maintain... 🤦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.