SSL/ACVP Test Integration for FIPS#1503
Open
DimensionWieldr wants to merge 5 commits intoAltinity:releases/25.3.8-fipsfrom
Open
SSL/ACVP Test Integration for FIPS#1503DimensionWieldr wants to merge 5 commits intoAltinity:releases/25.3.8-fipsfrom
DimensionWieldr wants to merge 5 commits intoAltinity:releases/25.3.8-fipsfrom
Conversation
Made-with: Cursor Signed-off-by: Julian Huang <jhuang@altinity.com>
Signed-off-by: Julian Huang <jhuang@altinity.com>
DimensionWieldr
force-pushed
the
releases/25.3.8-fips-ssl
branch
from
b1703f1 to
f4233e2
Compare
zvonand
reviewed
Mar 10, 2026
Collaborator
zvonand
left a comment
zvonand
left a comment
There was a problem hiding this comment.
Why do we have two identic glibc_compat.c files? Can it be moved into one place?
…ndshaker Move the identical glibc_compat.c files from ssl-shim/ and ssl-handshaker/ into a shared programs/ssl-common/ directory. Also add the gtest include path required by test_util.cc to both CMakeLists. Signed-off-by: Julian Huang <jhuang@altinity.com>
The FIPS 2.0.0 shim sources do not include any gtest headers, so this include path is not needed. Signed-off-by: Julian Huang <jhuang@altinity.com>
DimensionWieldr
force-pushed
the
releases/25.3.8-fips-ssl
branch
from
7e737fe to
4e4f1cf
Compare
Signed-off-by: Julian Huang <jhuang@altinity.com>
DimensionWieldr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
./runner_binary -shim-path .../build/programs/clickhouse-ssl-shim -handshaker-path .../build/programs/clickhouse-ssl-handshakergo run check_expected.go -tool .../aws-lc/build/acvptool -module-wrappers "modulewrapper:/whereveryoubuiltCH/programs/clickhouse-acvp-server,testmodulewrapper:/aws-lc/build/testmodulewrapper" -tests tests.jsonCI/CD Options
Exclude tests:
Regression jobs to run: