[WIP] Fix crash due to zero CHAT_ID_EXTRA in ConversationActivity

[Copilot]

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

CRASH in org.thoughtcrime.securesms.ConversationActivity.initializeResources()

the problem is that CHAT_ID_EXTRA passed to ConversationActivity is 0 not sure how could happen, checked several places where the intent is created and in most places it is checked if the chat id is !=0 and in others it should not be 0

Exception java.lang.IllegalStateException:
  at org.thoughtcrime.securesms.ConversationActivity.initializeResources (ConversationActivity.java:911)
  at org.thoughtcrime.securesms.ConversationActivity.onNewIntent (ConversationActivity.java:267)
  at android.app.Activity.onNewIntent (Activity.java:2422)
  at android.app.Activity.performNewIntent (Activity.java:9046)
  at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1648)
  at android.app.Instrumentation.internalCallActivityOnNewIntent (Instrumentation.java:1669)
  at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1657)
  at android.app.ActivityThread.deliverNewIntents (ActivityThread.java:4361)
  at android.app.ActivityThread.handleNewIntent (ActivityThread.java:4371)
  at android.app.servertransaction.NewIntentItem.execute (NewIntentItem.java:69)
  at android.app.servertransaction.ActivityTransactionItem.execute (ActivityTransactionItem.java:63)
  at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem (TransactionExecutor.java:133)
  at android.app.servertransaction.TransactionExecutor.executeTransactionItems (TransactionExecutor.java:103)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:80)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2719)
  at android.os.Handler.dispatchMessage (Handler.java:109)
  at android.os.Looper.loopOnce (Looper.java:232)
  at android.os.Looper.loop (Looper.java:317)
  at android.app.ActivityThread.main (ActivityThread.java:8787)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:591)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:871)

IMPORTANT: the crash log correspond to a previous version of the app, the code have been re-formatted recently so the line numbers will not match

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.