fix: validate ciphertext length in aes128 decryptBufferCBC#21571
Draft
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Draft
fix: validate ciphertext length in aes128 decryptBufferCBC#21571AztecBot wants to merge 1 commit intomerge-train/spartanfrom
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Conversation
d5b1e06 to
66579c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds input validation to
Aes128.decryptBufferCBCto return an empty buffer when ciphertext is empty or not a multiple of 16 bytes (the AES block size).PR #21192 added tests expecting this behavior but did not update the implementation, causing CI failure on merge-train/spartan.
Fix
Added early return guard in
decryptBufferCBC:Test plan
should return empty buffer for ciphertext not a multiple of 16now passesClaudeBox log: https://claudebox.work/s/60f97cca5a40e121?run=1