Skip to content

Make Start Date appear#1687

Open
bakobagassas wants to merge 14 commits intodevelopmentfrom
startDate2
Open

Make Start Date appear#1687
bakobagassas wants to merge 14 commits intodevelopmentfrom
startDate2

Conversation

@bakobagassas
Copy link
Copy Markdown
Contributor

@bakobagassas bakobagassas commented Mar 9, 2026

Issue Description

Fixes #1594

  • When doing the usability study, in reference to task " Create an Event that Repeats Three Weeks in a Series", participants often faced a problem in which the start date created on the main page (after picking an Event type within "Create Event"), when they turned on the toggle ("This is a series of Events") the start date would disappear and didnt transfer to the series. The start date selected outside of the modal should transfer into the modal and should still be editable.

Changes

  • Only js file, made it so that the event is carried into the box, same as the name and location.
  • Carried the date into the occurrence events
  • Carried the time too

Testing

  • Go to create an event
  • Select the program
  • Fill out name, location, and date
  • Click that it is a series of events
  • toggle the weekly repetition
  • You should see the name you previously inputted appear as the start date.

@bakobagassas bakobagassas requested a review from ojmakinde March 9, 2026 19:04
@bakobagassas bakobagassas self-assigned this Mar 9, 2026
@JohnCox2211 JohnCox2211 self-requested a review March 11, 2026 19:39
Copy link
Copy Markdown
Contributor

@JohnCox2211 JohnCox2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date appears in the multiple-offering modal when toggling 'This series repeats weekly'; however, it's not carried over when you press 'Add Occurrence', which I feel like it should.

I think it would also be good to carry over the time from the initial form into the modal, since that would be a good quality-of-life change and very similar to the date appearing in the modal.

@MImran2002 MImran2002 requested review from MImran2002 and removed request for MImran2002 March 16, 2026 21:47
Copy link
Copy Markdown
Contributor

@JohnCox2211 JohnCox2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The start/end time is not carried over when you press the add occurrence button in the series of events modal
  • After saving recurring events in the modal, then exiting the modal to save the event overall, there is a value error: ValueError: time data '4/3/2026 15:00' does not match format '%Y-%m-%d %H:%M'

@bakobagassas bakobagassas requested review from JohnCox2211 and MImran2002 and removed request for JohnCox2211 March 27, 2026 18:23
@bakobagassas
Copy link
Copy Markdown
Contributor Author

Ready for review.

def test_upcomingEvents():
with mainDB.atomic() as transaction:
testDate = datetime.strptime("2021-08-01 05:00","%Y-%m-%d %H:%M")
testDate = datetime.strptime("08/01/2021 05:00","%m/%d/%Y %H:%M")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know why do you have to change this because if there is a reason there are other places in the folder like test_participants > test_getEventLengthInHours() that should be change too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because I was carrying the date from the main page to the occurrences and to the series. However, the two were formatted differently because they initially got their dates from different sources. Therefore, when I carried the date there, I encountered some mismatches because the format on the front-end was different from what the backend expected. Hence why I had to change some of the formats and make the tests follow that. All tests are passing.

@github-actions
Copy link
Copy Markdown

View Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Start Date appear in the "This is a series of events" modal on Create Event page

3 participants