Conversation
JohnCox2211
left a comment
There was a problem hiding this comment.
The date appears in the multiple-offering modal when toggling 'This series repeats weekly'; however, it's not carried over when you press 'Add Occurrence', which I feel like it should.
I think it would also be good to carry over the time from the initial form into the modal, since that would be a good quality-of-life change and very similar to the date appearing in the modal.
JohnCox2211
left a comment
There was a problem hiding this comment.
- The start/end time is not carried over when you press the add occurrence button in the series of events modal
- After saving recurring events in the modal, then exiting the modal to save the event overall, there is a value error: ValueError: time data '4/3/2026 15:00' does not match format '%Y-%m-%d %H:%M'
|
Ready for review. |
| def test_upcomingEvents(): | ||
| with mainDB.atomic() as transaction: | ||
| testDate = datetime.strptime("2021-08-01 05:00","%Y-%m-%d %H:%M") | ||
| testDate = datetime.strptime("08/01/2021 05:00","%m/%d/%Y %H:%M") |
There was a problem hiding this comment.
I want to know why do you have to change this because if there is a reason there are other places in the folder like test_participants > test_getEventLengthInHours() that should be change too.
There was a problem hiding this comment.
I changed it because I was carrying the date from the main page to the occurrences and to the series. However, the two were formatted differently because they initially got their dates from different sources. Therefore, when I carried the date there, I encountered some mismatches because the format on the front-end was different from what the backend expected. Hence why I had to change some of the formats and make the tests follow that. All tests are passing.
Issue Description
Fixes #1594
Changes
Testing