Update STYLE_GUIDE: cancun default, optimizer/lint notes#4
Open
Update STYLE_GUIDE: cancun default, optimizer/lint notes#4
Conversation
CLI for people and AI agents — 31 Forge scripts, shell CLI, MCP server, and Claude Code skill. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nt notes - Default evm_version changed from paris to cancun (mainnet since March 2024) - Remove ci_sizes profile (redundant now that optimizer_runs is standard) - Add optimizer_runs=100 override note for revnet-core-v6 - Add lint_on_build=false note for repos with solar linter issues - Update CI example to use forge build --sizes directly Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the dual currency type system (abstract vs concrete) and the conversion boundaries where denomination bugs hide. This class of bug caused a real issue in tier split forwarding. Also add currency mixing to the anti-patterns table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evm_versionchanged fromparistocancun(mainnet since March 2024 Dencun upgrade)ci_sizesprofile (redundant — default optimizer_runs is sufficient)optimizer_runs = 100override note for revnet-core-v6 (stack-too-deep at 200 runs)lint_on_build = falsenote for repos with solar linter issuesforge build --sizesdirectly (no profile override)Companion to rev-net/revnet-core-v6#40.
Test plan
🤖 Generated with Claude Code