Split static and dynamic namespace contexts#2600
Open
GuntherRademacher wants to merge 1 commit intoBaseXdb:mainfrom
Open
Split static and dynamic namespace contexts#2600GuntherRademacher wants to merge 1 commit intoBaseXdb:mainfrom
GuntherRademacher wants to merge 1 commit intoBaseXdb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The namespace context previously mixed statically declared and dynamically scoped namespaces in
NSContext. AsNSContextinstances are shared per compiled module, this led to concurrency issues when dynamic namespace bindings were modified at runtime viaxquery:fork-join.This change separates concerns:
NSContextnow holds only statically declared (module) namespacesNSDynContextmaintains the dynamic namespace stack and is owned byQueryContextNSDynContextinstances are duplicated whenQueryContextis forked, ensuring thread isolationThis fixes concurrency issues with dynamic namespace handling. It handles all existing BaseX and QT4 tests in the same way as before. However this new test would fail:
The reason is in
QNm.compare: it needs access to the dynamic namespaces, which it does no longer have with the changes presented here. And addingQueryContext qcto the signature will cause a whole lot of further changes.