[FIX] Avoid internal corruption of TrieNodes#2614
Closed
brandes-pq wants to merge 1 commit intoBaseXdb:mainfrom
Closed
[FIX] Avoid internal corruption of TrieNodes#2614brandes-pq wants to merge 1 commit intoBaseXdb:mainfrom
brandes-pq wants to merge 1 commit intoBaseXdb:mainfrom
Conversation
In other parts of the code, the assumption is that a TrieNode of size 1 is always of class TrieLeaf. Removing the second-last item from a TrueBranch has violated this assumption, leading to ClassCastExceptions e.g. in XQTrieMap::put() or XQTrieMap::keys()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, I do not have a small query to show the problem, it occured in a very large query that executes a complex test suite.
The symptom was a crash with this message:
The general assumption in the code base is that a TrieNode of size 1 is always of class TrieLeaf, see e.g. in
XQTrieMap::put()orXQTrieMap::keys().Removing the second-last item from a TrieBranch has violated this assumption, returning a TreeBranch of size 1. This should be fixed with this patch.