Skip to content

feat: populate the sender address in intent for fillnonce and acceleration#8317

Open
sachinBitgo wants to merge 1 commit intomasterfrom
CGARD-511
Open

feat: populate the sender address in intent for fillnonce and acceleration#8317
sachinBitgo wants to merge 1 commit intomasterfrom
CGARD-511

Conversation

@sachinBitgo
Copy link
Contributor

CGARD-511

This pull request introduces a targeted update to the MpcUtils class, specifically enhancing how transaction intents are handled. The main change ensures that for certain intent types, an additional property is set on the intent object.

Enhancement to intent handling:

  • In mpcUtils.ts, when the intentType is either 'fillNonce' or 'acceleration', the senderAddress from the parameters is now explicitly added to the baseIntent object. This ensures that these intent types carry the necessary sender information for downstream processing.

Copy link
Contributor

@DinshawKothari DinshawKothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alextse-bg alextse-bg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, CI is failing tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants