fix: clamp negative amounts to 0 in AmountWrapper deserializer#215
Merged
fix: clamp negative amounts to 0 in AmountWrapper deserializer#215
Conversation
The staking service can send negative remainingStakingAmount (e.g. "-2282880") when the unstake amount exceeds the current balance. The u64 deserializer rejected these with "invalid digit found in string", preventing the intent from being processed at all. The intent builder already guards with > 0 checks before using amount values (e.g. partial unstake in build.rs), so clamping negatives to 0 at deserialization is safe and lets the full unstake path proceed correctly. Ticket: BTC-3184
davidkaplanbitgo
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The staking service can send negative remainingStakingAmount (e.g. "-2282880") when the unstake amount exceeds the current balance. The u64 deserializer rejected these with "invalid digit found in string", preventing the intent from being processed at all.
The intent builder already guards with > 0 checks before using amount values (e.g. partial unstake in build.rs), so clamping negatives to 0 at deserialization is safe and lets the full unstake path proceed correctly.
Ticket: BTC-3184