refactor: extract Recipient type in intentBuilder#217
Merged
Conversation
lcovar
force-pushed
the
refactor/recipient-type
branch
from
31c7cb7 to
58810ca
Compare
lcovar
force-pushed
the
refactor/recipient-type
branch
from
58810ca to
29701e9
Compare
PaymentIntent and ConsolidateIntent both had identical inline recipient shapes. Extract into a shared Recipient interface and export it from the package. Addresses review feedback from Otto on PR #208.
lcovar
force-pushed
the
refactor/recipient-type
branch
from
29701e9 to
adc2d4f
Compare
davidkaplanbitgo
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaymentIntent and ConsolidateIntent both had identical inline recipient shapes. Extract into a shared
Recipientinterface and export it from the package.Stacked on #BTC-3188 (consolidate token support).
Addresses review feedback from Otto on #208.