fix: make material required in DotTransaction.fromHex/fromBytes#219
Merged
fix: make material required in DotTransaction.fromHex/fromBytes#219
Conversation
Without material, the parser silently falls back to guessing the signed extension layout (assumes era + nonce + tip only). On chains with additional extensions (AuthorizeCall, StorageWeightReclaim, CheckMetadataHash, ChargeAssetTxPayment), this causes extra extension bytes to leak into call_data, producing silently corrupted transactions. All existing callers already pass material. Making it required turns a silent data corruption bug into a compile-time error. BTC-3062
lcovar
force-pushed
the
BTC-3062/require-material-in-fromhex
branch
from
b4ad071 to
9290793
Compare
davidkaplanbitgo
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
materiala required parameter inDotTransaction.fromHex()andDotTransaction.fromBytes()instead of optional.Without material, the parser silently falls back to guessing the signed extension layout (era + nonce + tip only). On chains with additional extensions (AuthorizeCall, StorageWeightReclaim, CheckMetadataHash, ChargeAssetTxPayment), extra extension bytes leak into call_data, producing silently corrupted transactions that the runtime rejects with a panic.
All existing callers already pass material. This turns a silent data corruption bug into a compile-time error.
Ticket: BTC-3062