serde: add stringify serializer over generic T:Display#340
Open
trevarj wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
serde: add stringify serializer over generic T:Display#340trevarj wants to merge 1 commit intoBlockstreamResearch:masterfrom
trevarj wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
trevarj
force-pushed
the
serde-stringify
branch
from
9708547 to
467111c
Compare
apoelstra
reviewed
Feb 18, 2026
src/serde/mod.rs
Outdated
| @@ -0,0 +1,3 @@ | |||
| // re-export of the serde crate | |||
| pub use ::serde::*; | |||
| pub mod stringify; | |||
Collaborator
There was a problem hiding this comment.
In 467111c:
I really don't like this. It's a weird trick to pretend that there are more things in the serde crate than there actually are.
Author
There was a problem hiding this comment.
That is true. Any reason for re-exporting serde?
Alternative module ideas:
rust_simplicity::serializers::stringifyrust_simplicity::value::serde::stringify(the serializer is generic so this really doesn't make sense)
Other ideas? What's your preference?
apoelstra
reviewed
Feb 18, 2026
Collaborator
|
CI failures are because the lockfile is not updated. |
- Added a crate `serializers` module - Added a simplicity::serializers::stringify module that contains a generic serializer over T: Display, which can be used with #[serde(with = "simplicity::serializers::stringify")] over a struct field - Added a unit test that uses string values from Value's `value_display` test - Updated Cargo-recent.lock to add serde_json Resolves BlockstreamResearch#330
trevarj
force-pushed
the
serde-stringify
branch
from
467111c to
8d64763
Compare
Author
|
Forced push with changing the module to |
trevarj
commented
Feb 20, 2026
| encode_natural(n, &mut w).expect("encoding to vector"); | ||
| w.flush_all().expect("flushing"); | ||
| let m = BitIter::from(sink.into_iter()) | ||
| let m: usize = BitIter::from(sink.into_iter()) |
Author
There was a problem hiding this comment.
Once I imported serde_json this type couldn't be inferred because of conflicting implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplicity::serde::stringifymodule that contains a generic serializerover
T: Display, which can be used with#[serde(with = "simplicity::serde::stringify")]over a struct fieldvalue_displaytestResolves #330