Skip to content

Add OperatorInfo message to track dive operator#254

Merged
follesoe merged 2 commits intomasterfrom
feature/operator-info
Mar 24, 2026
Merged

Add OperatorInfo message to track dive operator#254
follesoe merged 2 commits intomasterfrom
feature/operator-info

Conversation

@follesoe
Copy link
Copy Markdown
Member

Summary

  • Adds a new OperatorInfo message in message_formats.proto with name and email fields to identify the operator controlling the drone.
  • Adds an optional operator field to StartDiveCtrl in control.proto, so dive logs capture who started each dive.
  • Enables downstream use in reporting and when importing dives to Blueye Cloud.

Test plan

  • Verify proto files compile successfully (CI protolint + builds)
  • Confirm existing clients without operator info still work (field is optional in proto3)
  • Verify the new message appears in generated TypeScript, C#, and Python libraries

🤖 Generated with Claude Code

Introduce a new OperatorInfo message (name, email) in message_formats.proto
to identify the operator controlling the drone. Add it as an optional field
on StartDiveCtrl so dive logs capture who started each dive, enabling
reporting and Blueye Cloud import workflows.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@follesoe follesoe requested review from Copilot and jp-pino March 22, 2026 19:27
@follesoe follesoe self-assigned this Mar 22, 2026
@follesoe follesoe added the enhancement New feature or request label Mar 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds operator attribution to the control/logging protocol by introducing an OperatorInfo message and attaching it to StartDiveCtrl, enabling dive logs (and downstream imports) to record who initiated a dive.

Changes:

  • Added new OperatorInfo proto message with name and email.
  • Extended StartDiveCtrl with an operator field carrying OperatorInfo.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
protobuf_definitions/message_formats.proto Introduces OperatorInfo shared message for identifying a dive operator.
protobuf_definitions/control.proto Adds operator metadata to StartDiveCtrl for inclusion in logs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…lict

`operator` is a reserved keyword in C++ and C#, which would mangle
generated accessors. Renamed to `operator_info` while the field is new.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@follesoe follesoe requested a review from aviggen March 24, 2026 11:17
Copy link
Copy Markdown
Contributor

@aviggen aviggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would the user pick the operator? Is it only when the user is logged in in the app?

@follesoe
Copy link
Copy Markdown
Member Author

We can choose. It would be two string settings stored locally, that the user can set: Default Operator Name, and Default Operator Email.

After Blueye Cloud, we will get it from the signed in user. This will solve the case where say Trond does dives with a drone, and someone else synchronizes it, then in the Blueye Cloud, we can assign the operator automatically during ingestion.

@follesoe follesoe merged commit 66350af into master Mar 24, 2026
4 checks passed
@follesoe follesoe deleted the feature/operator-info branch March 24, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants